Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining legacy modules in RECO to support multi-threading #11140

Merged
merged 25 commits into from
Sep 11, 2015
Merged

Convert remaining legacy modules in RECO to support multi-threading #11140

merged 25 commits into from
Sep 11, 2015

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Sep 4, 2015

Converted the last remaining legacy reco modules that were taking some amount of time, as reported by igprof.

This PR is a copy of #10806, with merge conflicts fixed.

lgray and others added 23 commits August 21, 2015 09:59
@lgray
changes to MethodInvoker for thread safety
7a968f6
@lgray
convert ReducedEGProducer to edm::global
a754599
@lgray
convert PhysicsTools/PatAlgos and related to threaded modules
f46db26
@lgray
convert TopProjector to edm::stream
a972731
@lgray
convert GenParticlePruner to edm::stream
f0cc06c
@lgray
convert JetFlavourClustering to edm::stream
6f35aee
@lgray
convert JetDeltaRValueMapProducer to edm::global
ad0000d
@lgray
convert bits of RecoJets/JetProducers related to MiniAOD to threaded …
1e36461 
…modules
@lgray
convert HadronAndPartonSelector to edm::stream
2aeb16d
@lgray
convert JetChargeProducer to edm::global
665b25f
@lgray
convert bits of JetMETCorrections/Type1MET and PhysicsTools/PatUtils …
3cd94a0 
…related to MET and MiniAOD to threaded modules
@lgray
convert TauGenJetProducer to edm::global
755dcbb
@lgray
convert bits of CommonTools/RecoUtils related to MiniAOD to threaded …
cd4b5f8 
…modules
@lgray
fix small logic bug
d124195
@lgray
move NjettinessAdder to edm::one because of underlying statics
b040355
@lgray
code review resulting from helgrind, move modules from global to stre…
34c239d 
…am that contained reco::parser stuff
@lgray
remove using directives from headers in PatAlgos/plugins
27eea18
@lgray
RecoTauCleaner, PFRecoTauTagInfoProducer, PFTauSecondaryVertexProduce…
b76a913 
…r to modern modules
@lgray
move citk producer to edm::stream
cf18d67
@lgray
convert used modules in RecoLocalCalo/HcalRecProducers to edm::stream
b224983
@lgray
convert L1TCaloUpgradeToGCTConverter to edm::global
62803a0
@lgray
convert JetDeltaRTagInfoValueMapProducer to edm::global
1a151b7
@cvuosalo
Fixed conflicts
1e38731
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 4, 2015
@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@cvuosalo
I see a recent merge commit.
Which release is used?

@cvuosalo
Copy link
Contributor Author

@Slava: The IB used was CMSSW_7_6_X_2015-09-03-1100, the same as before.

@cmsbuild
Copy link
Contributor

Pull request #11140 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7366661
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11140/7988/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c77ca77
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11140/7988/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11140/7988/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11140/7988/summary.html

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@cvuosalo I checked the last updates and they seem fine now

BTW, please make PRs only from some descriptive topic branches (not from "merge-attempt")

@cvuosalo
Copy link
Contributor Author

+1

For #11140 7366661

Convert remaining legacy modules in RECO to support multi-threading. There should be no change in monitored quantities. This PR is derived from #10806 and is intended to fix its merge conflicts.

Jenkins tests against baseline CMSSW_7_6_X_2015-09-09-1100 show no significant differences, as expected. See #10806 for information about the performance of this PR.

This was referenced Sep 10, 2015
Merged
Merged
davidlange6 added a commit that referenced this pull request Sep 11, 2015
@davidlange6
Merge pull request #11140 from cvuosalo/merge-attempt
511fe1c 
Convert remaining legacy modules in RECO to support multi-threading
@davidlange6 davidlange6 merged commit 511fe1c into cms-sw:CMSSW_7_6_X Sep 11, 2015
@lgray
Copy link
Contributor

lgray commented Sep 11, 2015

@slava77 @cvuosalo I will start from this branch and construct new backports.

@davidlange6 I'll update the old ones.

This was referenced Sep 11, 2015
Merged
Merged
@slava77 slava77 mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@cvuosalo @cmsbuild @slava77 @lgray @davidlange6