Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate modules used by the HLT menu to multithreading (L1) #10956

Closed
wants to merge 1 commit into from
Closed

migrate modules used by the HLT menu to multithreading (L1) #10956

wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 26, 2015

This is the L1-only part of #10909 .

@fwyzard
L1TCaloUpgradeToGCTConverter: change into a global::EDProducer
b1cf79f 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - remove "using namespace" from header file
  - change into a global::EDProducer
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 26, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 26, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

migrate to modules used by the HLT menu multithreading (L1)

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: b1cf79f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10956/7673/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10956/7673/summary.html

This was referenced Aug 27, 2015
Closed
Merged
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2015

tracked at #10964

@mulhearn
Copy link
Contributor

mulhearn commented Sep 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@fwyzard - this does not merge now

@fwyzard fwyzard mentioned this pull request Sep 2, 2015
Merged
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2015

The history of these files is a mess :-(

Anyway, my commit already takes care of the namespace cleanup.
Can you do the merge with
git merge -Xtheirs fwyzard/migrate_to_multithreading_75x_L1
?

Otherwise you can pick #11072, where I just did that.

.A

@davidlange6 davidlange6 closed this Sep 3, 2015
@fwyzard fwyzard changed the title migrate to modules used by the HLT menu multithreading (L1) migrate modules used by the HLT menu to multithreading (L1) Sep 4, 2015
@fwyzard fwyzard deleted the migrate_to_multithreading_75x_L1 branch September 23, 2015 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @mulhearn @davidlange6