Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boosted cleaning fix for 75x #10013

Merged
merged 3 commits into from
Jul 8, 2015

Conversation

dsrankin
Copy link
Contributor

@dsrankin dsrankin commented Jul 2, 2015

Fixing const_cast issue.
Please approve as soon as possible, needed for data taking.
Backport of PR #10012
@rappoccio @isando3

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

A new Pull Request was created by @drankincms for CMSSW_7_5_X.

boosted cleaning fix for 75x

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

@drankincms
also need a 74X PR!!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

The tests are being triggered in jenkins.


std::vector<size_t> usedCands;

std::cout<<"----------------NEW EVENT----------------\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove cout statement

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2015

-1
Tested at: 1e536cc
When I ran the RelVals I found an error in the following worklfows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 02-Jul-2015 12:31:07 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 6
   [1] Running path 'HLT_Ele45_CaloIdVT_GsfTrkIdT_PFJet200_PFJet50_v2'
   [2] Calling event method for module HLTPFJetCollectionsFilter/'hltEle45CaloIdVTGsfTrkIdTDiCentralPFJet50EleCleaned'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector,reco::PFJet,edm::refhelper::FindUsingAdvance,reco::PFJet> > >
Looking for module label: hltEle45CaloIdVTGsfTrkIdTCleanAK4PFJet
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10013/10768/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants