-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in THashTable::Rehash in HLTFiltersDQMonitor #40419
Comments
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign dqm FYI @cms-sw/hlt-l2 |
New categories assigned: dqm @ahmad3213,@micsucmed,@rvenditti,@emanueleusai,@syuvivida,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks |
As far as I can tell, the only ROOT operations cmssw/DQMOffline/Trigger/plugins/HLTFiltersDQMonitor.cc Lines 148 to 160 in 9eb6ddb
cmssw/DQMOffline/Trigger/plugins/HLTFiltersDQMonitor.cc Lines 174 to 188 in 9eb6ddb
cmssw/DQMOffline/Trigger/plugins/HLTFiltersDQMonitor.cc Lines 223 to 240 in 9eb6ddb
Poking around in ROOT code I see If I recall/understood correctly the The locking in The relevant member functions in (or I'm completely wrong of the call chain) Adding @pcanal |
Fwiw, I couldn't reproduce the crash locally yet, and I haven't spotted it in other recent IBs. Trying to follow the analysis in #40419 (comment) ..
|
While testing locally (trying to insert an artificial delay to stream 0, although I didn't succeed in that yet), I was able to get a segfault
which demonstrates that somehow in this case |
I don't recall that we made it so. @lmoneta can you confirm whether this is the case or not? |
A better way would be to move the meMenu_ = iBooker.bookProfile(efficPlotNamePrefix_ + hltMenuName,
"Path Efficiency",
triggerNames.size(),
0.,
triggerNames.size(),
-0.1,
1.1,
"",
[&triggerNames](TProfile *profile) {
for (size_t idx = 0; idx < triggerNames.size(); ++idx) {
profile->GetXaxis()->SetBinLabel(idx + 1, triggerNames.[idx].c_str());
}
}); Then the |
Seen around a month ago,
Same run #, not sure if it is the same WF. |
@makortel, thanks for the suggestions in #40419 (comment) and #40419 (comment). I tried to implement a fix in #40426. |
As far as I know, #40426 fixed this problem. I wonder if it should be backported, though (for example, to |
If it can help the few MWGR's in which 12_6_X will be used, why not? |
Okay. Any reason to consider even lower cycles (12_4, 12_5) ? |
I don't think so, but I'd let it up to you |
Okay. #40536 is the 12_6_X backport. If others think other backports are useful, it can be discussed here. |
I think we should follow up with the bare ROOT object access from |
@cms-sw/dqm-l2 Based on #40676 (comment) , it's probably time to open a dedicated issue about deprecating/forbidding access to bare ROOT objects via |
Workflow 139.003 step 3 failed in CMSSW_13_0_X_2023-01-03-1100 on el8_amd64_gcc11 with
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc11/CMSSW_13_0_X_2023-01-03-1100/pyRelValMatrixLogs/run/139.003_RunHLTPhy2021/step3_RunHLTPhy2021.log#/
(I think I saw this error also earlier, but couldn't find it now)
The text was updated successfully, but these errors were encountered: