follow up to PR review of CPEFast to better reproduce Generic #34286

[slava77]

• adds back the TrackingRecHit2DSOAView::charge() accessor
• remove duplicate definitions of type aliases in CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)
• reduce repeated computations in RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)
• cleanup or clarify commented out code make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)
• cleanup or clarify commented out code make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)
• add reference to plot/documentation in make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)
• consider reading parameters from DB make CPEFast to better reproduce Generic (w/o track angle) #34286 (comment)

@VinInn @czangela @fwyzard

[cmsbuild]

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign reconstruction, heterogeneous

[cmsbuild]

New categories assigned: heterogeneous,reconstruction

@slava77,@fwyzard,@perrotta,@makortel,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

[VinInn]

addressed in #34419

[VinInn]

the "plot"

[slava77]

the "plot"

I guess that the point of the comment in #34286 was to have a link in the code
@mmusich may clarify the specifics.
If this was presented somewhere, perhaps a link to indico event/contribution is the most comprehensive.

[jpata]

+reconstruction

Looks like almost everything was addressed in #34882, except reading from DB (it was replaced with a named constant instead) #34286 (comment).