Uninitialized, unused member variable in SimCluster

[kpedro88]

While running valgrind for something else, I noticed the attached report of uninitialized values.

Looking at https://github.com/cms-sw/cmssw/blob/master/SimDataFormats/CaloAnalysis/interface/SimCluster.h and https://github.com/cms-sw/cmssw/blob/master/SimDataFormats/CaloAnalysis/src/SimCluster.cc, it seems that some of the member variables are definitely left uninitialized by some of the constructors.

I particularly noticed

cmssw/SimDataFormats/CaloAnalysis/interface/SimCluster.h

Line 219 in 442ae07

uint64_t nsimhits_;

, because it's never set or used anywhere, as far as I can tell.

It would be best to ensure that all primitive member variables are initialized by all constructors, and unused content is removed (saves memory, disk space, etc.).

[kpedro88]

assign simulation

[cmsbuild]

New categories assigned: simulation

@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @kpedro88 Kevin Pedro.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[civanch]

+1

was fixed with #36346

[civanch]

@kpedro88 , this issue may be closed now.

[cmsbuild]

This issue is fully signed and ready to be closed.