Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to L1 offline DQM - part 1 #19590

Closed
tapperad opened this issue Jul 6, 2017 · 9 comments
Closed

Improvements to L1 offline DQM - part 1 #19590

tapperad opened this issue Jul 6, 2017 · 9 comments

Comments

@tapperad
Copy link
Contributor

tapperad commented Jul 6, 2017

Here is a list of requested changes to:

cmssw/DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc

For the recoHTT and recoMHT we want to restrict the |eta| of the jets to < 2.5.

In the hardware the eta ranges and jet Et thresholds are set separately for HT and MHT (though they are currently the same value). Going forward it may be good to allow the same functionality in the DQM code i.e. separate configurable thresholds for eta range and Et threshold each for HT and MHT.

Cheers,
Alex.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

A new Issue was created by @tapperad .

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@tapperad tapperad changed the title Improvements to L1 trigger offline DQM Improvements to L1 offline DQM - part 1 Jul 6, 2017
@Dr15Jones
Copy link
Contributor

assign dqm, l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

New categories assigned: dqm,l1

@kmaeshima,@vanbesien,@mulhearn,@vazzolini,@dmitrijus,@rekovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tapperad
Copy link
Contributor Author

tapperad commented Jul 6, 2017

Hi, this issue should be assigned to @kreczko please.

cmsbuild pushed a commit that referenced this issue Aug 9, 2017
cmsbuild added a commit that referenced this issue Aug 9, 2017
[93X] Improvements to L1 Offline DQM - part 1 (issue #19590)
kreczko added a commit to kreczko/cmssw that referenced this issue Aug 22, 2017
@thomreis
Copy link
Contributor

thomreis commented Nov 2, 2017

Hi @tapperad @kreczko has this been resolved with the merged PRs?

@kreczko
Copy link
Contributor

kreczko commented Dec 14, 2017

@thomreis yes

@thomreis
Copy link
Contributor

+1
This could be closed.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants