Skip to content

Commit

Permalink
Thread friendly modules in EventFilter/EcalTBRawToDigi
Browse files Browse the repository at this point in the history
Convert to thread friendly module types
  • Loading branch information
Dr15Jones committed Jun 8, 2022
1 parent 03c0e6a commit e85ab2c
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 36 deletions.
10 changes: 2 additions & 8 deletions EventFilter/EcalTBRawToDigi/interface/EcalDCC07UnpackingModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

#include <FWCore/Framework/interface/MakerMacros.h>
#include <FWCore/Framework/interface/EDProducer.h>
#include <FWCore/Framework/interface/stream/EDProducer.h>
#include "FWCore/Utilities/interface/InputTag.h"

#include <iostream>
Expand All @@ -22,7 +22,7 @@ class CamacTBDataFormatter;
class TableDataFormatter;
class MatacqTBDataFormatter;

class EcalDCCTB07UnpackingModule : public edm::EDProducer {
class EcalDCCTB07UnpackingModule : public edm::stream::EDProducer<> {
public:
/// Constructor
EcalDCCTB07UnpackingModule(const edm::ParameterSet& pset);
Expand All @@ -33,12 +33,6 @@ class EcalDCCTB07UnpackingModule : public edm::EDProducer {
/// Produce digis out of raw data
void produce(edm::Event& e, const edm::EventSetup& c) override;

// BeginJob
void beginJob() override;

// EndJob
void endJob(void) override;

private:
EcalTB07DaqFormatter* formatter_;
EcalSupervisorTBDataFormatter* ecalSupervisorFormatter_;
Expand Down
10 changes: 2 additions & 8 deletions EventFilter/EcalTBRawToDigi/interface/EcalDCCUnpackingModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

#include <FWCore/Framework/interface/MakerMacros.h>
#include <FWCore/Framework/interface/EDProducer.h>
#include <FWCore/Framework/interface/stream/EDProducer.h>
#include "FWCore/Utilities/interface/InputTag.h"

#include <iostream>
Expand All @@ -21,7 +21,7 @@ class CamacTBDataFormatter;
class TableDataFormatter;
class MatacqTBDataFormatter;

class EcalDCCTBUnpackingModule : public edm::EDProducer {
class EcalDCCTBUnpackingModule : public edm::stream::EDProducer<> {
public:
/// Constructor
EcalDCCTBUnpackingModule(const edm::ParameterSet& pset);
Expand All @@ -32,12 +32,6 @@ class EcalDCCTBUnpackingModule : public edm::EDProducer {
/// Produce digis out of raw data
void produce(edm::Event& e, const edm::EventSetup& c) override;

// BeginJob
void beginJob() override;

// EndJob
void endJob(void) override;

private:
EcalTBDaqFormatter* formatter_;
EcalSupervisorTBDataFormatter* ecalSupervisorFormatter_;
Expand Down
4 changes: 0 additions & 4 deletions EventFilter/EcalTBRawToDigi/src/EcalDCC07UnpackingModule.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,6 @@ EcalDCCTB07UnpackingModule::EcalDCCTB07UnpackingModule(const edm::ParameterSet&

EcalDCCTB07UnpackingModule::~EcalDCCTB07UnpackingModule() { delete formatter_; }

void EcalDCCTB07UnpackingModule::beginJob() {}

void EcalDCCTB07UnpackingModule::endJob() {}

void EcalDCCTB07UnpackingModule::produce(edm::Event& e, const edm::EventSetup& c) {
edm::Handle<FEDRawDataCollection> rawdata;
e.getByLabel(fedRawDataCollectionTag_, rawdata);
Expand Down
4 changes: 0 additions & 4 deletions EventFilter/EcalTBRawToDigi/src/EcalDCCUnpackingModule.cc
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ EcalDCCTBUnpackingModule::EcalDCCTBUnpackingModule(const edm::ParameterSet& pset

EcalDCCTBUnpackingModule::~EcalDCCTBUnpackingModule() { delete formatter_; }

void EcalDCCTBUnpackingModule::beginJob() {}

void EcalDCCTBUnpackingModule::endJob() {}

void EcalDCCTBUnpackingModule::produce(edm::Event& e, const edm::EventSetup& c) {
edm::Handle<FEDRawDataCollection> rawdata;
e.getByLabel(fedRawDataCollectionTag_, rawdata);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
*
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>
#include <DataFormats/EcalRawData/interface/EcalRawDataCollections.h>
#include <iostream>
#include <vector>

class EcalDCCHeaderDumperModule : public edm::EDAnalyzer {
class EcalDCCHeaderDumperModule : public edm::one::EDAnalyzer<> {
public:
EcalDCCHeaderDumperModule(const edm::ParameterSet& ps) {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>
#include <DataFormats/EcalDigi/interface/EcalDigiCollections.h>
Expand All @@ -17,7 +17,7 @@
#include <iostream>
#include <vector>

class EcalDigiDumperModule : public edm::EDAnalyzer {
class EcalDigiDumperModule : public edm::one::EDAnalyzer<> {
public:
EcalDigiDumperModule(const edm::ParameterSet& ps) {
verbosity = ps.getUntrackedParameter<int>("verbosity", 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>
#include <DataFormats/EcalDigi/interface/EcalDigiCollections.h>
Expand All @@ -21,7 +21,7 @@
#include "TFile.h"
#include "TGraph.h"

class EcalGraphDumperModule : public edm::EDAnalyzer {
class EcalGraphDumperModule : public edm::one::EDAnalyzer<> {
public:
EcalGraphDumperModule(const edm::ParameterSet& ps);
~EcalGraphDumperModule();
Expand Down
4 changes: 2 additions & 2 deletions EventFilter/EcalTBRawToDigi/test/stubs/EcalHexDumperModule.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <DataFormats/Common/interface/Handle.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>
Expand All @@ -23,7 +23,7 @@

#include <iomanip>

class EcalHexDumperModule : public edm::EDAnalyzer {
class EcalHexDumperModule : public edm::one::EDAnalyzer<> {
public:
EcalHexDumperModule(const edm::ParameterSet& ps)
: fedRawDataCollectionTag_(ps.getParameter<edm::InputTag>("fedRawDataCollectionTag")) {
Expand Down
4 changes: 2 additions & 2 deletions EventFilter/EcalTBRawToDigi/test/stubs/EcalMatacqHist.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* </UL>
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>

Expand All @@ -24,7 +24,7 @@
class TProfile;
class TH1D;

class EcalMatacqHist : public edm::EDAnalyzer {
class EcalMatacqHist : public edm::one::EDAnalyzer<> {
public:
EcalMatacqHist(const edm::ParameterSet& ps);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*
*/

#include <FWCore/Framework/interface/EDAnalyzer.h>
#include <FWCore/Framework/interface/one/EDAnalyzer.h>
#include <FWCore/Framework/interface/Event.h>
#include <FWCore/Framework/interface/MakerMacros.h>
#include <DataFormats/EcalDigi/interface/EcalDigiCollections.h>
Expand All @@ -24,7 +24,7 @@
#include "TFile.h"
#include "TGraph.h"

class EcalPnGraphDumperModule : public edm::EDAnalyzer {
class EcalPnGraphDumperModule : public edm::one::EDAnalyzer<> {
public:
EcalPnGraphDumperModule(const edm::ParameterSet& ps);
~EcalPnGraphDumperModule();
Expand Down

0 comments on commit e85ab2c

Please sign in to comment.