upgrade's comments

(cherry picked from commit b07a309)
cms-sw · Sep 30, 2022 · e4b0c83 · e4b0c83
1 parent c2cd223
commit e4b0c83
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/L1Trigger/Phase2L1ParticleFlow/interface/regionizer/multififo_regionizer_elements_ref.icc b/L1Trigger/Phase2L1ParticleFlow/interface/regionizer/multififo_regionizer_elements_ref.icc
@@ -53,10 +53,12 @@ void l1ct::multififo_regionizer::RegionBuffer<T>::initFifos(unsigned int nfifos)
     for (auto& t : queues_.back().second)
       t.clear();
   }
-  if (!(nfifos == 1 || nfifos == 2 || nfifos == 3 || nfifos == 4 || nfifos == 6 || nfifos == 8 || nfifos == 12)) {
+  bool isGood =
+      (nfifos == 1 || nfifos == 2 || nfifos == 3 || nfifos == 4 || nfifos == 6 || nfifos == 8 || nfifos == 12);
+  if (!isGood) {
     dbgCerr() << "Error, created regionizer for nfifos == " << nfifos << ", not supported." << std::endl;
   }
-  assert(nfifos == 1 || nfifos == 2 || nfifos == 3 || nfifos == 4 || nfifos == 6 || nfifos == 8 || nfifos == 12);
+  assert(isGood);
 }
 
 template <typename T>

diff --git a/L1Trigger/Phase2L1ParticleFlow/plugins/L1TCorrelatorLayer1Producer.cc b/L1Trigger/Phase2L1ParticleFlow/plugins/L1TCorrelatorLayer1Producer.cc
@@ -77,7 +77,7 @@ class L1TCorrelatorLayer1Producer : public edm::stream::EDProducer<> {
   const std::string regionDumpName_;
   bool writeRawHgcalCluster_;
   std::fstream fRegionDump_;
-  std::vector<edm::ParameterSet> patternWriterConfigs_;
+  const std::vector<edm::ParameterSet> patternWriterConfigs_;
   std::vector<std::unique_ptr<L1TCorrelatorLayer1PatternFileWriter>> patternWriters_;
 
   // region of interest debugging