Merge pull request #46535 from smuzaffar/ubsan-ReduceMantissaToNbitsR…

…ounding-suppress-shift [UBSAN]Suppess -ve shift error for ReduceMantissaToNbitsRounding
cms-sw · Oct 29, 2024 · ce5ea58 · ce5ea58
2 parents 5754132 + cd9abc7
commit ce5ea58
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/DataFormats/Math/interface/libminifloat.h b/DataFormats/Math/interface/libminifloat.h
@@ -51,6 +51,10 @@ class MiniFloatConverter {
 
   class ReduceMantissaToNbitsRounding {
   public:
+#ifdef CMS_UNDEFINED_SANITIZER
+    //Supress UBSan runtime error about -ve shift. This happens when bits==23
+    __attribute__((no_sanitize("shift")))
+#endif
     ReduceMantissaToNbitsRounding(int bits)
         : shift(23 - bits), mask((0xFFFFFFFF >> (shift)) << (shift)), test(1 << (shift - 1)), maxn((1 << bits) - 2) {
       assert(bits <= 23);  // "max mantissa size is 23 bits"