Skip to content

Commit

Permalink
Make static plugin maker instances const
Browse files Browse the repository at this point in the history
The maker classes used by the plugin system only have const interfaces so it is safe to make all the static instance of these classes const. This shows the intent better and allows the static analyzer to better understand what is happening.
  • Loading branch information
Dr15Jones committed Dec 12, 2013
1 parent a548aef commit bdd879d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion FWCore/PluginManager/interface/PluginFactory.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,5 +99,5 @@ namespace edmplugin {\
#define EDM_PLUGIN_SYM2(x,y) x ## y

#define DEFINE_EDM_PLUGIN(factory,type,name) \
[[cms::thread_safe]] static factory::PMaker<type> EDM_PLUGIN_SYM(s_maker , __LINE__ ) (name)
static const factory::PMaker<type> EDM_PLUGIN_SYM(s_maker , __LINE__ ) (name)

0 comments on commit bdd879d

Please sign in to comment.