There is no use to fill negative values to log scaled axes, just do n…

…othing if comparison can't be done

DQM/HcalCommon/interface/ValueQuantity.h

@@ -202,8 +202,8 @@ namespace hcaldqm {
         {fADC_256_4, -0.5},
         {fEtlog2, 0.},
         {fDiffRatio, -2.5},
-        {fCPUenergy, -1},
-        {fGPUenergy, -1},
+        {fCPUenergy, 0},
+        {fGPUenergy, 0},
     };
     const std::map<ValueQuantityType, double> max_value = {
         {fN, 1000},
@@ -333,8 +333,8 @@ namespace hcaldqm {
         {fADC_256_4, 64},
         {fEtlog2, 9},
         {fDiffRatio, 50},
-        {fCPUenergy, 1005},
-        {fGPUenergy, 1005},
+        {fCPUenergy, 1000},
+        {fGPUenergy, 1000},
     };
     class ValueQuantity : public Quantity {
     public:

DQM/HcalTasks/plugins/HcalGPUComparisonTask.cc

@@ -96,24 +96,9 @@ HcalGPUComparisonTask::HcalGPUComparisonTask(edm::ParameterSet const& ps)
   auto const chbhe_ref = e.getHandle(tokHBHE_ref_);
   auto const chbhe_target = e.getHandle(tokHBHE_target_);
 
-  if (not(chbhe_ref.isValid() and chbhe_target.isValid())) {
-    if (chbhe_target.isValid()) {
-      edm::LogWarning("HcalGPUComparisonTask")
-          << "The CPU HBHERecHitCollection " << tagHBHE_ref_.encode() << " is not available";
-
-      for (auto const& rh : *chbhe_target)
-        energyGPUvsCPU_subdet_.fill(rh.id(), -0.5, rh.energy());
-    } else if (chbhe_ref.isValid()) {
-      edm::LogWarning("HcalGPUComparisonTask")
-          << "The GPU HBHERecHitCollection " << tagHBHE_target_.encode() << " is not available";
-
-      for (auto const& rh : *chbhe_ref)
-        energyGPUvsCPU_subdet_.fill(rh.id(), rh.energy(), -0.5);
-    } else {
-      edm::LogWarning("HcalGPUComparisonTask")
-          << "Neither CPU nor GPU RecHit Collection available, will not fill this event.";
-    }
-
+  if (not(chbhe_ref.isValid() or chbhe_target.isValid())) {
+    edm::LogWarning("HcalGPUComparisonTask")
+        << "Either CPU or GPU RecHit Collection is available, will not fill this event.";
     return;
   }