Skip to content

Commit

Permalink
it has been reported that inference in the unit test does not pass on…
Browse files Browse the repository at this point in the history
… ARM and PPC architectures.

Apparently "abs" is a floating point variant round only on x86_64, so converting it to std::abs
  • Loading branch information
smorovic committed Mar 25, 2024
1 parent 8202a6d commit a0ed168
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion RecoEgamma/PhotonIdentification/test/test_PhotonMvaXgb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ TEST_CASE("RecoEgamma/PhotonIdentification testXGBPhoton", "[TestPhotonMvaXgb]")
float xgbScore;
const float *v = vars_in[i];
float etaSC = v[6];
if (abs(etaSC) < 1.5)
if (std::abs(etaSC) < 1.5)
xgbScore = mvaEstimatorB->computeMva(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7], v[8]);
else
xgbScore = mvaEstimatorE->computeMva(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7], v[8]);
Expand Down

0 comments on commit a0ed168

Please sign in to comment.