[DQM] clang-tidy Performance inefficient vector operation sugegstion …

…applied
cms-sw · May 24, 2023 · 6d81624 · 6d81624
1 parent 8cc6f24
commit 6d81624
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/DQM/GEM/src/GEMDQMBase.cc b/DQM/GEM/src/GEMDQMBase.cc
@@ -147,6 +147,7 @@ int GEMDQMBase::SortingLayers(std::vector<ME3IdsKey>& listLayers) {
 
 dqm::impl::MonitorElement* GEMDQMBase::CreateSummaryHist(DQMStore::IBooker& ibooker, TString strName) {
   std::vector<ME3IdsKey> listLayers;
+  listLayers.reserve(mapStationInfo_.size());
   for (auto const& [key, stationInfo] : mapStationInfo_)
     listLayers.push_back(key);
   SortingLayers(listLayers);

diff --git a/DQMOffline/Trigger/plugins/LepHTMonitor.cc b/DQMOffline/Trigger/plugins/LepHTMonitor.cc
@@ -360,9 +360,11 @@ void LepHTMonitor::bookHistograms(DQMStore::IBooker &ibooker, const edm::Run &iR
 
   //Convert to vfloat for picky TH1F constructor
   vector<float> f_ptbins;
+  f_ptbins.reserve(ptbins_.size());
   for (double ptbin : ptbins_)
     f_ptbins.push_back(static_cast<float>(ptbin));
   vector<float> f_htbins;
+  f_htbins.reserve(htbins_.size());
   for (double htbin : htbins_)
     f_htbins.push_back(static_cast<float>(htbin));
 

diff --git a/DQMOffline/Trigger/src/EgHLTOffHelper.cc b/DQMOffline/Trigger/src/EgHLTOffHelper.cc
@@ -256,6 +256,7 @@ int OffHelper::fillOffEleVec(std::vector<OffEle>& egHLTOffEles) {
     ele.setLooseCutCode(eleLooseCuts_.getCutCode(ele));
 
     std::vector<std::pair<TrigCodes::TrigBitSet, int> > trigCutsCutCodes;
+    trigCutsCutCodes.reserve(trigCuts_.size());
     for (auto& trigCut : trigCuts_)
       trigCutsCutCodes.push_back(std::make_pair(trigCut.first, trigCut.second.getCutCode(ele)));
     ele.setTrigCutsCutCodes(trigCutsCutCodes);
@@ -425,6 +426,7 @@ int OffHelper::fillOffPhoVec(std::vector<OffPho>& egHLTOffPhos) {
     pho.setLooseCutCode(phoLooseCuts_.getCutCode(pho));
 
     std::vector<std::pair<TrigCodes::TrigBitSet, int> > trigCutsCutCodes;
+    trigCutsCutCodes.reserve(trigCuts_.size());
     for (auto& trigCut : trigCuts_)
       trigCutsCutCodes.push_back(std::make_pair(trigCut.first, trigCut.second.getCutCode(pho)));
     pho.setTrigCutsCutCodes(trigCutsCutCodes);