Merge pull request #31256 from perrotta/reduceWarninLinesPerEvent

Warn about bit number above trigger collections sizes only once per event/bx
cms-sw · Sep 8, 2020 · 56e25f2 · 56e25f2
2 parents 8a44670 + 0445ac2
commit 56e25f2
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/L1Trigger/L1TGlobal/src/GlobalBoard.cc b/L1Trigger/L1TGlobal/src/GlobalBoard.cc
@@ -874,6 +874,7 @@ void l1t::GlobalBoard::runFDL(edm::Event& iEvent,
     int inBxInEvent = totalBxInEvent / 2 + iBxInEvent;
 
     bool temp_algPrescaledOr = false;
+    bool alreadyReported = false;
     for (unsigned int iBit = 0; iBit < numberPhysTriggers; ++iBit) {
       bool bitValue = m_uGtAlgBlk.getAlgoDecisionInitial(iBit);
       if (bitValue) {
@@ -895,8 +896,10 @@ void l1t::GlobalBoard::runFDL(edm::Event& iEvent,
             temp_algPrescaledOr = true;
           }
         }  // require bit in range
-        else {
-          edm::LogWarning("L1TGlobal") << "\nWarning: algoBit >= prescaleFactorsAlgoTrig.size() " << std::endl;
+        else if (!alreadyReported) {
+          alreadyReported = true;
+          edm::LogWarning("L1TGlobal") << "\nWarning: algoBit >= prescaleFactorsAlgoTrig.size() in bx " << iBxInEvent
+                                       << std::endl;
         }
       }  //if algo bit is set true
     }    //loop over alg bits
@@ -915,6 +918,7 @@ void l1t::GlobalBoard::runFDL(edm::Event& iEvent,
 
   if (!algorithmTriggersUnmasked) {
     bool temp_algFinalOr = false;
+    bool alreadyReported = false;
     for (unsigned int iBit = 0; iBit < numberPhysTriggers; ++iBit) {
       bool bitValue = m_uGtAlgBlk.getAlgoDecisionInterm(iBit);
 
@@ -923,8 +927,10 @@ void l1t::GlobalBoard::runFDL(edm::Event& iEvent,
         bool isMasked = false;
         if (iBit < triggerMaskAlgoTrig.size())
           isMasked = (triggerMaskAlgoTrig.at(iBit) == 0);
-        else {
-          edm::LogWarning("L1TGlobal") << "\nWarning: algoBit >= triggerMaskAlgoTrig.size() " << std::endl;
+        else if (!alreadyReported) {
+          alreadyReported = true;
+          edm::LogWarning("L1TGlobal") << "\nWarning: algoBit >= triggerMaskAlgoTrig.size() in bx " << iBxInEvent
+                                       << std::endl;
         }
 
         bool passMask = (bitValue && !isMasked);