Digest::fromHexifiedString now uses a std::string_view

cms-sw · Nov 22, 2024 · 4fb8f1a · 4fb8f1a
1 parent 3b53b20
commit 4fb8f1a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/DataFormats/Provenance/src/CompactHash.cc b/DataFormats/Provenance/src/CompactHash.cc
@@ -32,7 +32,7 @@ namespace edm {
 
     std::array<unsigned char, 16> fromHex_(std::string_view v) {
       cms::MD5Result temp;
-      temp.fromHexifiedString(std::string(v));
+      temp.fromHexifiedString(v);
       auto hash = temp.compactForm();
       std::array<unsigned char, 16> ret;
       std::copy(hash.begin(), hash.end(), ret.begin());

diff --git a/FWCore/Utilities/interface/Digest.h b/FWCore/Utilities/interface/Digest.h
@@ -28,7 +28,7 @@ namespace cms {
     std::string compactForm() const;
 
     // Set our data from the given hexdigest string.
-    void fromHexifiedString(std::string const& s);
+    void fromHexifiedString(std::string_view);
 
     bool isValid() const;
   };

diff --git a/FWCore/Utilities/src/Digest.cc b/FWCore/Utilities/src/Digest.cc
@@ -114,13 +114,13 @@ namespace cms {
     return std::string(p, p + bytes.size());
   }
 
-  void MD5Result::fromHexifiedString(std::string const& hexy) {
+  void MD5Result::fromHexifiedString(std::string_view hexy) {
     switch (hexy.size()) {
       case 0: {
         set_to_default(*this);
       } break;
       case 32: {
-        std::string::const_iterator it = hexy.begin();
+        auto it = hexy.cbegin();
         for (size_t i = 0; i != 16; ++i) {
           // first nybble
           bytes[i] = (unhexify(*it++) << 4);