Merge pull request #46181 from iarspider/iarspider-patch-20241001-2

[LLVM Analyzer] Avoid storing pointer to a temporary string's internal buffer in SiPixelFakeGenErrorDBObjectESSource::produce and SiPixelTemplateDBObjectReader::analyze
cms-sw · Oct 12, 2024 · 32c7e17 · 32c7e17
2 parents 21636e8 + 19c25e2
commit 32c7e17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/CalibTracker/SiPixelESProducers/plugins/SiPixelFakeGenErrorDBObjectESSource.cc b/CalibTracker/SiPixelESProducers/plugins/SiPixelFakeGenErrorDBObjectESSource.cc
@@ -23,7 +23,6 @@ std::unique_ptr<SiPixelGenErrorDBObject> SiPixelFakeGenErrorDBObjectESSource::pr
   SiPixelGenErrorDBObject* obj = new SiPixelGenErrorDBObject;
 
   // Local variables
-  const char* tempfile;
   int m;
 
   // Set the number of GenErrors to be passed to the dbobject
@@ -35,9 +34,7 @@ std::unique_ptr<SiPixelGenErrorDBObject> SiPixelFakeGenErrorDBObjectESSource::pr
   //  open the GenError file(s)
   for (m = 0; m < obj->numOfTempl(); ++m) {
     edm::FileInPath file(GenErrorCalibrations_[m].c_str());
-    tempfile = (file.fullPath()).c_str();
-
-    std::ifstream in_file(tempfile, std::ios::in);
+    std::ifstream in_file(file.fullPath(), std::ios::in);
 
     if (in_file.is_open()) {
       edm::LogInfo("SiPixelFakeGenErrorDBObjectESSource")
@@ -84,7 +81,7 @@ std::unique_ptr<SiPixelGenErrorDBObject> SiPixelFakeGenErrorDBObjectESSource::pr
       in_file.close();
     } else {
       // If file didn't open, report this
-      edm::LogError("SiPixeFakelGenErrorDBObjectESSource") << "Error opening File" << tempfile << std::endl;
+      edm::LogError("SiPixeFakelGenErrorDBObjectESSource") << "Error opening File" << file.fullPath() << std::endl;
     }
   }
 

diff --git a/CondTools/SiPixel/plugins/SiPixelTemplateDBObjectReader.cc b/CondTools/SiPixel/plugins/SiPixelTemplateDBObjectReader.cc
@@ -114,7 +114,6 @@ void SiPixelTemplateDBObjectReader::analyze(const edm::Event& iEvent, const edm:
     edm::LogPrint("SiPixelTemplateDBObjectReader") << std::endl;
 
     //local variables
-    const char* tempfile;
     int numOfTempl = dbobject.numOfTempl();
     int index = 0;
     float tempnum = 0, diff = 0;
@@ -139,8 +138,7 @@ void SiPixelTemplateDBObjectReader::analyze(const edm::Event& iEvent, const edm:
            << std::right << dbobject.sVector()[index] << ".out" << std::ends;
 
       edm::FileInPath file(tout.str());
-      tempfile = (file.fullPath()).c_str();
-      std::ifstream in_file(tempfile, std::ios::in);
+      std::ifstream in_file(file.fullPath(), std::ios::in);
 
       if (in_file.is_open()) {
         //Removes header in textfile from diff