Add assertions to stubbed out code paths.

cms-sw · Nov 12, 2019 · 22c7d19 · 22c7d19
1 parent b815a0d
commit 22c7d19
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/DQM/SiPixelMonitorClient/src/SiPixelConfigWriter.cc b/DQM/SiPixelMonitorClient/src/SiPixelConfigWriter.cc
@@ -14,7 +14,10 @@ SiPixelConfigWriter::~SiPixelConfigWriter() {}
 //
 // -- Initialize XML
 //
-bool SiPixelConfigWriter::init() { return true; }
+bool SiPixelConfigWriter::init() {
+  assert(!"No longer implemented.");
+  return true;
+}
 //
 // -- Add an Element
 //

diff --git a/DQM/SiPixelMonitorClient/src/SiPixelLayoutParser.cc b/DQM/SiPixelMonitorClient/src/SiPixelLayoutParser.cc
@@ -1,6 +1,7 @@
 #include "DQM/SiPixelMonitorClient/interface/SiPixelLayoutParser.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include <iostream>
+#include <cassert>
 
 using namespace std;
 
@@ -18,5 +19,6 @@ SiPixelLayoutParser::SiPixelLayoutParser() {
 //
 bool SiPixelLayoutParser::getAllLayouts(map<string, vector<string>> &layouts) {
   // TODO: implement parser based on property_tree.
+  assert(!"No longer implemented.");
   return false;
 }
diff --git a/DQM/SiStripCommissioningClients/src/SummaryPlotXmlParser.cc b/DQM/SiStripCommissioningClients/src/SummaryPlotXmlParser.cc
@@ -2,6 +2,7 @@
 #include "DataFormats/SiStripCommon/interface/SiStripEnumsAndStrings.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include <stdexcept>
+#include <cassert>
 
 using namespace sistrip;
 
@@ -27,6 +28,7 @@ std::vector<SummaryPlot> SummaryPlotXmlParser::summaryPlots(const sistrip::RunTy
 void SummaryPlotXmlParser::parseXML(const std::string& f) {
   plots_.clear();
   // TODO: implement parser based on property tree.
+  assert(!"No longer implemented.");
 }
 
 // -----------------------------------------------------------------------------

diff --git a/DQM/SiStripMonitorClient/src/SiStripConfigWriter.cc b/DQM/SiStripMonitorClient/src/SiStripConfigWriter.cc
@@ -14,7 +14,10 @@ SiStripConfigWriter::~SiStripConfigWriter() {}
 //
 // -- Initialize XML
 //
-bool SiStripConfigWriter::init(std::string main) { return true; }
+bool SiStripConfigWriter::init(std::string main) {
+  assert(!"No longer implemented.");
+  return true;
+}
 //
 // -- Add an Element to the top node
 //

diff --git a/DQM/SiStripMonitorClient/src/SiStripLayoutParser.cc b/DQM/SiStripMonitorClient/src/SiStripLayoutParser.cc
@@ -1,6 +1,7 @@
 #include "DQM/SiStripMonitorClient/interface/SiStripLayoutParser.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include <iostream>
+#include <cassert>
 
 //
 // -- Constructor
@@ -10,7 +11,8 @@ SiStripLayoutParser::SiStripLayoutParser() {
                                       << "\n";
 }
 void SiStripLayoutParser::getDocument(std::string filepath) {
-  // TODO: add new parser.
+  // TODO: add new parser based on boost::property_tree.
+  assert(!"No longer implemented.");
 }
 //
 // -- Get list of Layouts for ME groups