Skip to content

Commit

Permalink
No need to check into base classes of std classes
Browse files Browse the repository at this point in the history
From Philippe Canal. Checking existence of dictionaries for base
classes of std classes caused missing dictionary errors for
__pair_base with GCC 12.
  • Loading branch information
makortel committed Jun 9, 2023
1 parent 59b0f36 commit 17364e1
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions FWCore/Reflection/src/DictionaryTools.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ to have dictionaries.
#include "FWCore/Utilities/interface/WrappedClassName.h"

#include "TClass.h"
#include "TClassEdit.h"
#include "THashTable.h"

#include <algorithm>
Expand Down Expand Up @@ -328,6 +329,12 @@ namespace edm {
return true;
}

// No need to check into base classes of standard library
// classes.
if (TClassEdit::IsStdClass(typeWithDict.name().c_str())) {
return true;
}

TypeBases bases(typeWithDict);
bool returnValue = true;
for (auto const& basex : bases) {
Expand Down

0 comments on commit 17364e1

Please sign in to comment.