-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We were cycling memory each time a module put a data product into the event. This now has the ParentageID hold the 16 bytes directly instead of indirectly via a std::string.
- Loading branch information
Showing
6 changed files
with
287 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,163 @@ | ||
#ifndef DataFormats_Provenance_CompactHash_h | ||
#define DataFormats_Provenance_CompactHash_h | ||
|
||
#include <string_view> | ||
#include <array> | ||
#include <functional> | ||
|
||
namespace cms { | ||
class Digest; | ||
} | ||
|
||
namespace edm { | ||
|
||
namespace detail { | ||
// This string is the 16-byte, non-printable version. | ||
std::array<unsigned char, 16> const& InvalidCompactHash(); | ||
} // namespace detail | ||
|
||
namespace compact_hash_detail { | ||
using value_type = std::array<unsigned char, 16>; | ||
void toString_(std::string& result, value_type const& hash); | ||
void toDigest_(cms::Digest& digest, value_type const& hash); | ||
std::ostream& print_(std::ostream& os, value_type const& hash); | ||
bool isValid_(value_type const& hash); | ||
size_t smallHash_(value_type const& hash); | ||
value_type fromHex_(std::string_view); | ||
void throwIfIllFormed(std::string_view v); | ||
} // namespace compact_hash_detail | ||
|
||
template <int I> | ||
class CompactHash { | ||
public: | ||
typedef compact_hash_detail::value_type value_type; | ||
|
||
CompactHash(); | ||
explicit CompactHash(value_type const& v); | ||
explicit CompactHash(std::string_view v); | ||
|
||
CompactHash(CompactHash<I> const&) = default; | ||
CompactHash<I>& operator=(CompactHash<I> const& iRHS) = default; | ||
|
||
CompactHash(CompactHash<I>&&) = default; | ||
CompactHash<I>& operator=(CompactHash<I>&&) = default; | ||
|
||
void reset(); | ||
|
||
// For now, just check the most basic: a default constructed | ||
// ParameterSetID is not valid. This is very crude: we are | ||
// assuming that nobody created a ParameterSetID from an empty | ||
// string, nor from any string that is not a valid string | ||
// representation of an MD5 checksum. | ||
bool isValid() const; | ||
|
||
bool operator<(CompactHash<I> const& other) const; | ||
bool operator>(CompactHash<I> const& other) const; | ||
bool operator==(CompactHash<I> const& other) const; | ||
bool operator!=(CompactHash<I> const& other) const; | ||
std::ostream& print(std::ostream& os) const; | ||
void toString(std::string& result) const; | ||
void toDigest(cms::Digest& digest) const; | ||
|
||
// Return the 16-byte (non-printable) string form. | ||
value_type const& compactForm() const; | ||
|
||
///returns a short hash which can be used with hashing containers | ||
size_t smallHash() const; | ||
|
||
//Used by ROOT storage | ||
// CMS_CLASS_VERSION(3) // This macro is not defined here, so expand it. | ||
static short Class_Version() { return 3; } | ||
|
||
private: | ||
template <typename Op> | ||
bool compareUsing(CompactHash<I> const& iOther, Op op) const { | ||
return op(this->hash_, iOther.hash_); | ||
} | ||
|
||
value_type hash_; | ||
}; | ||
|
||
//-------------------------------------------------------------------- | ||
// | ||
// Implementation details follow... | ||
//-------------------------------------------------------------------- | ||
|
||
template <int I> | ||
inline CompactHash<I>::CompactHash() : hash_(detail::InvalidCompactHash()) {} | ||
|
||
template <int I> | ||
inline CompactHash<I>::CompactHash(value_type const& v) : hash_(v) {} | ||
|
||
template <int I> | ||
inline CompactHash<I>::CompactHash(std::string_view v) { | ||
if (v.size() == 32) { | ||
hash_ = compact_hash_detail::fromHex_(v); | ||
} else { | ||
compact_hash_detail::throwIfIllFormed(v); | ||
std::copy(v.begin(), v.end(), hash_.begin()); | ||
} | ||
} | ||
|
||
template <int I> | ||
inline void CompactHash<I>::reset() { | ||
hash_ = detail::InvalidCompactHash(); | ||
} | ||
|
||
template <int I> | ||
inline bool CompactHash<I>::isValid() const { | ||
return compact_hash_detail::isValid_(hash_); | ||
} | ||
|
||
template <int I> | ||
inline bool CompactHash<I>::operator<(CompactHash<I> const& other) const { | ||
return this->compareUsing(other, std::less<value_type>()); | ||
} | ||
|
||
template <int I> | ||
inline bool CompactHash<I>::operator>(CompactHash<I> const& other) const { | ||
return this->compareUsing(other, std::greater<value_type>()); | ||
} | ||
|
||
template <int I> | ||
inline bool CompactHash<I>::operator==(CompactHash<I> const& other) const { | ||
return this->compareUsing(other, std::equal_to<value_type>()); | ||
} | ||
|
||
template <int I> | ||
inline bool CompactHash<I>::operator!=(CompactHash<I> const& other) const { | ||
return this->compareUsing(other, std::not_equal_to<value_type>()); | ||
} | ||
|
||
template <int I> | ||
inline std::ostream& CompactHash<I>::print(std::ostream& os) const { | ||
return compact_hash_detail::print_(os, hash_); | ||
} | ||
|
||
template <int I> | ||
inline void CompactHash<I>::toString(std::string& result) const { | ||
compact_hash_detail::toString_(result, hash_); | ||
} | ||
|
||
template <int I> | ||
inline void CompactHash<I>::toDigest(cms::Digest& digest) const { | ||
compact_hash_detail::toDigest_(digest, hash_); | ||
} | ||
|
||
template <int I> | ||
inline typename CompactHash<I>::value_type const& CompactHash<I>::compactForm() const { | ||
return hash_; | ||
} | ||
|
||
template <int I> | ||
inline size_t CompactHash<I>::smallHash() const { | ||
return compact_hash_detail::smallHash_(hash_); | ||
} | ||
|
||
template <int I> | ||
inline std::ostream& operator<<(std::ostream& os, CompactHash<I> const& h) { | ||
return h.print(os); | ||
} | ||
|
||
} // namespace edm | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
#include "DataFormats/Provenance/interface/CompactHash.h" | ||
#include "FWCore/Utilities/interface/Algorithms.h" | ||
#include "FWCore/Utilities/interface/Digest.h" | ||
#include "FWCore/Utilities/interface/EDMException.h" | ||
|
||
#include <functional> | ||
#include <cassert> | ||
|
||
namespace { | ||
std::array<unsigned char, 16> convert(std::string const& v) { | ||
assert(v.size() == 16); | ||
std::array<unsigned char, 16> retValue; | ||
std::copy(v.begin(), v.end(), retValue.begin()); | ||
return retValue; | ||
} | ||
} // namespace | ||
namespace edm { | ||
namespace detail { | ||
// This string is the 16-byte, non-printable version. | ||
std::array<unsigned char, 16> const& InvalidCompactHash() { | ||
static std::array<unsigned char, 16> const invalid = convert(cms::MD5Result().compactForm()); | ||
return invalid; | ||
} | ||
} // namespace detail | ||
|
||
namespace compact_hash_detail { | ||
size_t smallHash_(value_type const& hash) { | ||
//NOTE: In future we could try to xor the first 8bytes into the second 8bytes of the string to make the hash | ||
std::hash<std::string_view> h; | ||
return h(std::string_view(reinterpret_cast<const char*>(hash.data()), hash.size())); | ||
} | ||
|
||
std::array<unsigned char, 16> fromHex_(std::string_view v) { | ||
cms::MD5Result temp; | ||
temp.fromHexifiedString(std::string(v)); | ||
auto hash = temp.compactForm(); | ||
std::array<unsigned char, 16> ret; | ||
std::copy(hash.begin(), hash.end(), ret.begin()); | ||
return ret; | ||
} | ||
|
||
bool isValid_(value_type const& hash) { return hash != detail::InvalidCompactHash(); } | ||
|
||
void throwIfIllFormed(std::string_view v) { | ||
// Fixup not needed here. | ||
if (v.size() != 16) { | ||
throw Exception(errors::LogicError) << "Ill-formed CompactHash instance. " | ||
<< "A string_view of size " << v.size() << " passed to constructor."; | ||
} | ||
} | ||
|
||
void toString_(std::string& result, value_type const& hash) { | ||
cms::MD5Result temp; | ||
copy_all(hash, temp.bytes.begin()); | ||
result += temp.toString(); | ||
} | ||
|
||
void toDigest_(cms::Digest& digest, value_type const& hash) { | ||
cms::MD5Result temp; | ||
copy_all(hash, temp.bytes.begin()); | ||
digest.append(temp.toString()); | ||
} | ||
|
||
std::ostream& print_(std::ostream& os, value_type const& hash) { | ||
cms::MD5Result temp; | ||
copy_all(hash, temp.bytes.begin()); | ||
os << temp.toString(); | ||
return os; | ||
} | ||
} // namespace compact_hash_detail | ||
} // namespace edm |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
<bin name="testDataFormatsProvenance" file="testRunner.cpp,eventid_t.cppunit.cc,timestamp_t.cppunit.cc,parametersetid_t.cppunit.cc,indexIntoFile_t.cppunit.cc,indexIntoFile1_t.cppunit.cc,indexIntoFile2_t.cppunit.cc,indexIntoFile3_t.cppunit.cc,indexIntoFile4_t.cppunit.cc,indexIntoFile5_t.cppunit.cc,lumirange_t.cppunit.cc,eventrange_t.cppunit.cc,compactEventAuxiliaryVector_t.cppunit.cc"> | ||
<use name="cppunit"/> | ||
<use name="DataFormats/Provenance"/> | ||
<bin name="testDataFormatsProvenance" file="testRunner.cpp,eventid_t.cppunit.cc,timestamp_t.cppunit.cc,parametersetid_t.cppunit.cc,indexIntoFile_t.cppunit.cc,indexIntoFile1_t.cppunit.cc,indexIntoFile2_t.cppunit.cc,indexIntoFile3_t.cppunit.cc,indexIntoFile4_t.cppunit.cc,indexIntoFile5_t.cppunit.cc,lumirange_t.cppunit.cc,eventrange_t.cppunit.cc,compactEventAuxiliaryVector_t.cppunit.cc"> | ||
</bin> | ||
|
||
<bin name="testDataFormatsProvenanceCatch2" file="ElementID_t.cpp,Parentage_t.cpp,StoredProcessBlockHelper_t.cpp"> | ||
<bin name="testDataFormatsProvenanceCatch2" file="ElementID_t.cpp,Parentage_t.cpp,StoredProcessBlockHelper_t.cpp,CompactHash_t.cpp"> | ||
<use name="DataFormats/Provenance"/> | ||
<use name="catch2"/> | ||
</bin> | ||
|
||
<bin name="testProductResolverIndexHelper" file="testRunner.cpp productResolverIndexHelper_t.cppunit.cc"> | ||
<use name="DataFormats/TestObjects"/> | ||
<use name="cppunit"/> | ||
<use name="DataFormats/Provenance"/> | ||
</bin> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#include "catch.hpp" | ||
|
||
#include "DataFormats/Provenance/interface/CompactHash.h" | ||
#include "FWCore/Utilities/interface/Digest.h" | ||
|
||
namespace { | ||
using TestHash = edm::CompactHash<100>; | ||
} | ||
|
||
TEST_CASE("CompactHash", "[CompactHash]") { | ||
SECTION("Default construction is invalid") { REQUIRE(TestHash{}.isValid() == false); } | ||
|
||
SECTION("Basic operations") { | ||
cms::Digest d("foo"); | ||
auto result = d.digest().bytes; | ||
|
||
TestHash id{result}; | ||
REQUIRE(id.isValid() == true); | ||
REQUIRE(id.compactForm() == result); | ||
|
||
TestHash id2 = id; | ||
REQUIRE(id2.isValid() == true); | ||
REQUIRE(id2.compactForm() == result); | ||
|
||
cms::Digest b("bar"); | ||
auto diffResult = b.digest().bytes; | ||
REQUIRE(id2 == TestHash{result}); | ||
REQUIRE(id2 != TestHash{diffResult}); | ||
|
||
REQUIRE(id2 > TestHash{diffResult}); | ||
REQUIRE(TestHash{diffResult} < id2); | ||
|
||
REQUIRE(not(id2 < id2)); | ||
} | ||
} |