Merge pull request #31585 from cms-tau-pog/CMSSW_10_6_X_tau-pog_PVref…

…itFixForTauRecoAtMini

Protect against ill-defined track momenta and reffited tau vertices for tauReco@mini (10_6_X)

RecoTauTag/RecoTau/plugins/PFTauMiniAODPrimaryVertexProducer.cc

@@ -65,6 +65,8 @@ void PFTauMiniAODPrimaryVertexProducer::nonTauTracksInPVFromPackedCands(const si
 
   //Find candidates/tracks associated to thePV
   for(const auto& cand: cands){
+    //MB: Skip candidates with ill-defined momentum as they return ill-defined tracks (why it happens?)
+    if (!std::isfinite(cand.pt())) continue;  //MB: it is enough to check just pt (?)
     if(cand.vertexRef().isNull()) continue;
     int quality = cand.pvAssociationQuality();
     if(cand.vertexRef().key()!=thePVkey ||

RecoTauTag/RecoTau/src/PFTauPrimaryVertexProducerBase.cc

@@ -183,6 +183,13 @@ void PFTauPrimaryVertexProducerBase::produce(edm::Event& iEvent,const edm::Event
 	  } else {
 	    transVtx = avf.vertex(transTracks, *beamSpot);
 	  }
+	  if (!transVtx.isValid()) {
+	    fitOK = false;
+	  } else {
+	    //MB: protect against rare cases when transVtx is valid but its position is ill-defined
+	    if (!std::isfinite(transVtx.position().z())) //MB: it is enough to check one coordinate (?)
+	      fitOK = false;
+	  }
 	} else fitOK = false;
 	if ( fitOK ) thePV = transVtx;
       }