Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of the ROCm flags #91

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 2, 2023

Fix the order of the ROCm flags, to allow ROCM_FLAGS to override CXXFLAGS.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch scramv3.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 2, 2023

please test

@smuzaffar
Copy link
Contributor

@fwyzard , this looks safe to me, I can merge it and add the new tag for next IB

@smuzaffar smuzaffar merged commit 0d9b303 into cms-sw:scramv3 Feb 2, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 2, 2023

Thank you !

@fwyzard fwyzard deleted the fix_ROCm_flags_order branch February 2, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants