-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.1.X] Backport multi-arch chanegs from 15.0.X #9573
Conversation
test parameters:
|
please test |
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master. @aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a786d/43405/summary.html Comparison SummarySummary:
|
@smuzaffar |
@antoniovilela , I would like to get this in for 14.2.X first. |
Sounds good |
+externals 14.2.X IB looks good so lets merge this for 14.1.X |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar |
@antoniovilela , no idea but I am looking in to it |
Many thankks. We will wait a bit, before we launch the 14_2 & 15_0 builds. |
I think cms-sw/cmssw-config@91e7bf6 change broke the python impor. I am reverting that change . Change was needed for runing edm class check during patch release built. We have a work around for that cms-sw/cmssw#46922 . Can you please integrate cms-sw/cmssw#46922 . I will revert the cms-sw/cmssw-config@91e7bf6 foo all release cycles 14.1 and above |
cms-sw/cmssw#46922 is merged. Ok, we will wait for the revert. |
@makortel , cms-sw/cmssw-config@91e7bf6 change was using the realpath of imported python package. This was done so that edm class check script can import
After the cmssw-config update for python imports, in patch releases , imported python module path starts with
The reason unit test https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_15_0_X_2024-12-13-1100/unitTestLogs/FWCore/Integration#/3356-3356 start failing was that https://github.com/cms-sw/cmssw/blob/master/FWCore/ParameterSet/python/Config.py#L55 only allows CMSSW_RELEASE_BASE and CMSSW_BASE. For now I have reverted the cmssw-config change. But do you think we should update https://github.com/cms-sw/cmssw/blob/master/FWCore/ParameterSet/python/Config.py#L55 and also allow CMSSW_FULL_RELEASE_BASE ? |
I have opened a cmssw issue for this |
same as #9572