-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -fno-omit-frame-pointer as default flag for compilation #9565
Add -fno-omit-frame-pointer as default flag for compilation #9565
Conversation
A new Pull Request was created by @gartung for branch IB/CMSSW_15_0_X/master. @aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test |
test parameters:
|
please test |
@gartung , any specific reason to add this? have you done any performance studies? If I understand correctly |
I agree that it may be a useful addition for debugging and profiling, but I would like to check the impact on the HLT performance before merging this. |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Checking EDM Class Transients in libDataFormatsCLHEP.so @@@@ ----> OK EDM Class Version >> Checking EDM Class Transients in libDataFormatsCSCDigi.so @@@@ ----> OK EDM Class Version >> Checking EDM Class Transients in libDataFormatsCSCRecHit.so error: class 'CTPPSDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1554945820 error: class 'TotemRPDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1915602617 error: class 'CTPPSDiamondDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3253161212 error: class 'CTPPSPixelDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1640295022 error: class 'TotemTimingDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3647294361 Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/CTPPSDetId/src/classes_def.xml.generated with updated ClassVersion |
This is meant to improve profiling. |
I have not done any performance studies. |
Can you suggest a workflow to test the HLT timing? |
Unfortunately no, nothing out of the box :-/ |
OK |
please test |
Thanks |
please test with #9568 |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 2 errors in the following unit tests: ---> test TestDQMOfflineConfigurationGotAll had ERRORS ---> test testFWCoreConcurrency had ERRORS Comparison SummarySummary:
|
Closing for now as this did not improve the attribution of orphaned call stacks in gprofng or perf. Perf implements lbr stack stitching which still produces orphaned stacks. Vtune uses the vendor knowledge that TBB keeps track of the pointer to the spawned process that executes the code. |
No description provided.