Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -fno-omit-frame-pointer as default flag for compilation #9565

Closed

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 10, 2024

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung for branch IB/CMSSW_15_0_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2024

cms-bot internal usage

@gartung
Copy link
Member Author

gartung commented Dec 10, 2024

please test

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

@gartung , any specific reason to add this? have you done any performance studies? If I understand correctly -fno-omit-frame-pointer is good for debugging applications

@fwyzard
Copy link
Contributor

fwyzard commented Dec 10, 2024

I agree that it may be a useful addition for debugging and profiling, but I would like to check the impact on the HLT performance before merging this.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43367/summary.html
COMMIT: d8fda17
CMSSW: CMSSW_15_0_X_2024-12-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9565/43367/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43367/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43367/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libDataFormatsCLHEP.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCSCDigi.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsCSCRecHit.so
error: class 'CTPPSDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1554945820
error: class 'TotemRPDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1915602617
error: class 'CTPPSDiamondDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3253161212
error: class 'CTPPSPixelDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1640295022
error: class 'TotemTimingDetId' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 3647294361
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/CTPPSDetId/src/classes_def.xml.generated with updated ClassVersion


@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

This is meant to improve profiling.

@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

I have not done any performance studies.

@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

Can you suggest a workflow to test the HLT timing?

@fwyzard
Copy link
Contributor

fwyzard commented Dec 11, 2024

Can you suggest a workflow to test the HLT timing?

Unfortunately no, nothing out of the box :-/

@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

OK

@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

please test

@smuzaffar
Copy link
Contributor

please test with #9568

@gartung without #9568 test will fail again

@gartung
Copy link
Member Author

gartung commented Dec 11, 2024

Thanks

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43382/summary.html
COMMIT: d8fda17
CMSSW: CMSSW_15_0_X_2024-12-11-0800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9565/43382/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43382/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43382/git-merge-result

Unit Tests

I found 23 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS
---> test EventFilterUtilitiesReadStreamerFile had ERRORS
---> test TestDQMOfflineConfiguration_70 had ERRORS
and more ...

RelVals

  • 2024.101001DAS Error
  • 2024.202001DAS Error

@gartung
Copy link
Member Author

gartung commented Dec 12, 2024

please test with #9568

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43419/summary.html
COMMIT: d8fda17
CMSSW: CMSSW_15_0_X_2024-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9565/43419/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43419/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c119d0/43419/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS
---> test testFWCoreConcurrency had ERRORS

Comparison Summary

Summary:

@gartung
Copy link
Member Author

gartung commented Dec 12, 2024

Closing for now as this did not improve the attribution of orphaned call stacks in gprofng or perf. Perf implements lbr stack stitching which still produces orphaned stacks. Vtune uses the vendor knowledge that TBB keeps track of the pointer to the spawned process that executes the code.

@gartung gartung closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants