Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let icpx find the gcc installation #9290

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 9, 2024

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

A new Pull Request was created by @fwyzard for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2024

@smuzaffar this is how we make ROCm / hipcc find the GCC headers. The same expanded arguments work for icpx, but I'm not sure if COMPILER_PATH will be defined properly ?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2024

FYI @AuroraPerego

@smuzaffar
Copy link
Contributor

@smuzaffar this is how we make ROCm / hipcc find the GCC headers. The same expanded arguments work for icpx, but I'm not sure if COMPILER_PATH will be defined properly ?

COMPILER_PATH is set as runtime env by gcc tools, so it should be defined and points to our installation of GCC root directory. --gcc-toolchain=$(COMPILER_PATH) should work.

By the way, are we doing to add some cmssw code which we might not be able to compile outside CERN ( note that icx installed under /cvmfs/projects.cern.ch/ will only be accessible without CERN) ?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2024

Eventually, yes, maybe.

But we are also discussing a legal agreement with Intel in order to redistribute ICX/ICPX.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f8e2d/40304/summary.html
COMMIT: f7b1a2e
CMSSW: CMSSW_14_1_X_2024-07-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9290/40304/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f8e2d/40304/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f8e2d/40304/git-merge-result

Build

I found compilation error when building:

TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02845/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-07-07-0000/lib/el8_amd64_gcc12/CondFormatsHIObjects_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.30/07 of ROOT.
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCondFormatsCSCObjects.so
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02845/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-07-07-0000/lib/el8_amd64_gcc12/CondFormatsGBRForest_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.30/07 of ROOT.
Suggestion: You can run 'scram build updateclassversion' to generate src/CondFormats/HcalObjects/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libCondFormatsHcalObjects.so] Error 1
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02845/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-07-07-0000/lib/el8_amd64_gcc12/SimDataFormatsEncodedEventId_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.30/07 of ROOT.
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02845/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_X_2024-07-07-0000/lib/el8_amd64_gcc12/CondFormatsGBRForest_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.30/07 of ROOT.
>> Checking EDM Class Version for src/CondFormats/DTObjects/src/classes_def.xml in libCondFormatsDTObjects.so
Error in : ROOT PCM /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02845/el8_amd64_gcc12/external/python3/3.9.14-c10287ae9cadff55334e60003302c349/bin/CondFormatsHcalObjects_xr_rdict.pcm file does not exist
Info in : In-memory ROOT PCM candidate /pool/condor/dir_3732376/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.30.09-01326d9a7ad53c2865b416adce95f583/lib/libASImageGui_rdict.pcm


@smuzaffar
Copy link
Contributor

we need a new IB with root 6.30.08. lets wait for tonight IB

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 1331608 into cms-sw:IB/CMSSW_14_1_X/master Jul 10, 2024
7 of 8 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f8e2d/40313/summary.html
COMMIT: f7b1a2e
CMSSW: CMSSW_14_1_X_2024-07-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9290/40313/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 10-Jul-2024 09:45:45 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [7] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 1.20331 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

@fwyzard fwyzard deleted the IB/CMSSW_14_1_X/master_icx_2024.1 branch July 10, 2024 14:16
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 10, 2024

@smuzaffar looking at the areas created by the cms bot, I don't see any changes to icx-cxxcompiler.xml 🤷🏻‍♂️

I'll check the IB tomorrow.

@smuzaffar
Copy link
Contributor

icx-*compiler.xml files are not selected by default and they are available under config/toolbox/$SCRAM_ARCH/tools/available. As for PR tests this available directory is not used so that is why you do not see icx-*.xml in the PR create installation area.

It will be available in tonight's IBs

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 10, 2024

OK, thanks !

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 11, 2024

Looks good in today's IB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants