Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Added support to link default lib to the alpaka backends #9263

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 24, 2024

See cms-sw/cmssw#45285 .
Adding <flags USE_ALPAKA="1"/> OR <flags USE_ALPAKA="Subsystem/Package"/> will add dependency on Subsystem/Package for all the alpaka backends. This is same as using

<use name="1" for="alpaka"/>
OR
<use name="SubSystem/Package" for="alpaka"/>

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9f9b/40032/summary.html
COMMIT: 0f540c5
CMSSW: CMSSW_14_1_X_2024-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9263/40032/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9f9b/40032/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9f9b/40032/git-merge-result

Unit Tests

I found 7 errors in the following unit tests:

---> test testOnlineBeamMonitor had ERRORS
---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS
---> test TestDQMOfflineConfigurationGotAll had ERRORS
and more ...

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

unit tests failures are not related to this change

@smuzaffar smuzaffar merged commit c482941 into IB/CMSSW_14_1_X/master Jun 24, 2024
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants