Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow-xla-runtime.spec #9072

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38147/summary.html
COMMIT: 12475e4
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38147/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

26 | #define EIGEN_STATIC_ASSERT(X,MSG) static_assert(X,#MSG);
|                                                  ^
make[2]: *** [CMakeFiles/tf_xla_runtime_objects.dir/build.make:118: CMakeFiles/tf_xla_runtime_objects.dir/tensorflow/compiler/xla/service/cpu/runtime_conv2d.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/tf_xla_runtime_objects.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.yYbMaC (%build)


RPM build errors:
line 42: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow-xla-runtime+2.12.0-ffe6bfc273abf714c0de82ab45b0e11d
Bad exit status from /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.yYbMaC (%build)


@cmsbuild
Copy link
Contributor

Pull request #9072 was updated.

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@iarspider
Copy link
Contributor Author

please abort

@smuzaffar
Copy link
Contributor

@iarspider thanks for reminding me that we should also use the eigen flags here

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38158/summary.html
COMMIT: 398bf38
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_ppc64le_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38158/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/RecoTracker/TrackProducer/test/TrackAnalyzer.cc
>> Building edm plugin tmp/el8_ppc64le_gcc12/src/RecoTracker/TrackProducer/test/TrackAnalyzer/libTrackAnalyzer.so
Leaving library rule at src/RecoTracker/TrackProducer/test
@@@@ Running edmWriteConfigs for TrackAnalyzer
cp: cannot create regular file 'cfipython/el8_ppc64le_gcc12/RecoTracker/TrackProducer/modules.py': File exists
gmake: *** [lib/el8_ppc64le_gcc12/TrackAnalyzer.edmplugin] Error 1
Entering library rule at src/RecoTracker/TrackProducer/test
>> Compiling edm plugin src/RecoTracker/TrackProducer/test/TrackValidator.cc
>> Building edm plugin tmp/el8_ppc64le_gcc12/src/RecoTracker/TrackProducer/test/TrackValidator/libTrackValidator.so
Leaving library rule at src/RecoTracker/TrackProducer/test
@@@@ Running edmWriteConfigs for TrackValidator


@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38157/summary.html
COMMIT: 398bf38
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38157/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38157/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38157/git-merge-result

@cmsbuild
Copy link
Contributor

Pull request #9072 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9072 was updated.

@iarspider
Copy link
Contributor Author

please test for el8_aarch64_gcc12

@iarspider
Copy link
Contributor Author

please test for el8_ppc64le_gcc12

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38164/summary.html
COMMIT: 651305d
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38164/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38164/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38164/git-merge-result

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38165/summary.html
COMMIT: 651305d
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_ppc64le_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38165/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhysicsToolsSelectorUtilsPythonTestsDriver had ERRORS

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c007b6/38174/summary.html
COMMIT: 651305d
CMSSW: CMSSW_14_1_X_2024-03-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9072/38174/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3288140
  • DQMHistoTests: Total failures: 3335
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3284785
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.092 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.156 KiB HLT/Filters
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 7 / 46 workflows

@iarspider
Copy link
Contributor Author

---> test testPhysicsToolsSelectorUtilsPythonTestsDriver had ERRORS
Error occurs in IBs, not related to this PR.

@iarspider iarspider requested a review from smuzaffar March 15, 2024 20:35
@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit eab900d into IB/CMSSW_14_1_X/master Mar 15, 2024
20 of 21 checks passed
@smuzaffar smuzaffar deleted the tf-xla-non-x86 branch March 26, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants