Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm to version 5.6.1 [14.0.x] #9052

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 6, 2024

Update ROCm to version 5.6.1:

Add the ROCm packages to support OpenMP and Thrust:

  • the OpenMP packages are required to compile any source that uses #pragma omp ... with hipcc;
  • the Thrust packages are needed for compatibility with CUDA, and are used by the HIP backend of PyTorch.

Backport of #9050 to the data taking release.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 6, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 6, 2024

backport #9050

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

A new Pull Request was created by @fwyzard for branch IB/CMSSW_14_0_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c4cc/37930/summary.html
COMMIT: 0fb823a
CMSSW: CMSSW_14_0_X_2024-03-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9052/37930/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Build successful rocm.
(, , ) done
Trying to install the rpm package external+rocm+5.6.1-6320ba1f36f64f70428881e859817e3e just built.
Checking local path dependency for rpm package external+rocm+5.6.1-6320ba1f36f64f70428881e859817e3e just build.
RPM installation stderr rocm:
error: Failed dependencies:
	libffi.so.6()(64bit) is needed by external+rocm+5.6.1-6320ba1f36f64f70428881e859817e3e-1-1.x86_64
	libpython3.6m.so.1.0()(64bit) is needed by external+rocm+5.6.1-6320ba1f36f64f70428881e859817e3e-1-1.x86_64

Failed to install RPM for rocm
Requested to quit.


@fwyzard fwyzard force-pushed the IB/CMSSW_14_0_X/master_rocm-5.6.1 branch from 0fb823a to cd74fa5 Compare March 6, 2024 13:17
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

Pull request #9052 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c4cc/37934/summary.html
COMMIT: cd74fa5
CMSSW: CMSSW_14_0_X_2024-03-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9052/37934/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 35 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342239
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342207
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.600000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.225 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 7, 2024

type bugfix

@smuzaffar
Copy link
Contributor

please test

lets refresh the tests here. I am afraid it missed 14.0.2 release

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02c4cc/38154/summary.html
COMMIT: cd74fa5
CMSSW: CMSSW_14_0_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9052/38154/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346226
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346198
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 18, 2024

@smuzaffar @antoniovilela @rappoccio any objections to having this in the next 14.0.x release ?

@smuzaffar
Copy link
Contributor

+externals

its a backport of #9050 (from 14.1.X) . @antoniovilela @rappoccio feel free to sign/merge it for 14.0.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 5cee4c0 into cms-sw:IB/CMSSW_14_0_X/master Mar 18, 2024
9 checks passed
@antoniovilela
Copy link

@smuzaffar @antoniovilela @rappoccio any objections to having this in the next 14.0.x release ?

Please use @cms-sw/orp-l2

@antoniovilela
Copy link

+externals

its a backport of #9050 (from 14.1.X) . @antoniovilela @rappoccio feel free to sign/merge it for 14.0.X

Please use @cms-sw/orp-l2

@fwyzard fwyzard deleted the IB/CMSSW_14_0_X/master_rocm-5.6.1 branch April 7, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants