[DO NOT MERGE] Test making Eigen alignment setting consistent #9043

makortel · 2024-02-29T20:05:52Z

Following cms-sw/cmssw#44188 (comment) This PR attempts to use consistent alignment options for Eigen in the remaining externals depending on Eigen.

I skipped professor2 because of not feeling proficient enough in RPM spec syntax, and it not being linked against in CMSSW.

I think we'd also want a better way to propagate these settings.

makortel · 2024-02-29T20:06:01Z

@cmsbuild, please test

cmsbuild · 2024-02-29T20:06:13Z

A new Pull Request was created by @makortel for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-02-29T20:06:14Z

cms-bot internal usage

cmsbuild · 2024-03-01T03:16:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37832/summary.html
COMMIT: 1580fa1
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9043/37832/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37832/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37832/git-merge-result

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 49 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3338784
DQMHistoTests: Total failures: 68
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338694
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

lwtnn.spec

iarspider · 2024-03-06T22:26:54Z

I will try to figure it out.

cmsbuild · 2024-03-07T15:10:12Z

Pull request #9043 was updated.

makortel · 2024-03-07T15:10:53Z

@cmsbuild, please test

cmsbuild · 2024-03-08T05:51:05Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37960/summary.html
COMMIT: d2f3620
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@fwyzard Update ROCm to version 5.6.1 #9050

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37960/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dec1c/37960/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

24900.0

----- Begin Fatal Exception 08-Mar-2024 06:25:00 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/VertexFinder/data/NNVtx_WeightModelGraph.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24900.0_CloseByPGun_CE_H_Coarse_Scint+2026D98


At:
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(972): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(965): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

24896.0

----- Begin Fatal Exception 08-Mar-2024 06:25:13 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/VertexFinder/data/NNVtx_WeightModelGraph.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24896.0_CloseByPGun_CE_E_Front_120um+2026D98


At:
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(972): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(965): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

24834.0

----- Begin Fatal Exception 08-Mar-2024 06:28:13 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/VertexFinder/data/NNVtx_WeightModelGraph.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-03-06-2300/src
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.0_TTbar_14TeV+2026D98


At:
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(972): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Types.py(965): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9043/37960/CMSSW_14_1_X_2024-03-06-2300/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

makortel · 2024-03-08T14:42:35Z

Based on the tests in cms-sw/cmssw#44188 (comment) and cms-sw/cmssw#44188 (comment) this PR seems to resolve cms-sw/cmssw#44188.

@smuzaffar @iarspider Would this PR be good-enough to be deployed as is? Or do we want these changes done in some better way? Some possible issues I could think of

Build recipe of professor2 should also be updated correspondingly
Is this way proper also for the MULTIARCHS build?
- If not, should that be addressed in this PR (or equivalent), or later?
I'm not happy with the amount of copy-paste of this special setting

smuzaffar · 2024-03-08T14:52:07Z

@makortel , I would like to redo this to avoid copy pasting the eigen flags and enabling these extra packages for multi-arch builds. I will do it on Monday

makortel · 2024-03-08T14:54:32Z

Thanks @smuzaffar. I'll close this PR then (it did its purpose).

perrotta · 2024-03-11T12:11:48Z

@makortel , I would like to redo this to avoid copy pasting the eigen flags and enabling these extra packages for multi-arch builds. I will do it on Monday

Thank you @smuzaffar
Please let me point out that such PR will be needed rather urgently by the TkAl team, and we'll request a new release as soon as that one (as well as cms-sw/cmssw#44359 and
cms-sw/cmsdist#9057) will get merged in 14_0_X

smuzaffar · 2024-03-11T13:39:46Z

FYI @perrotta : #9060

perrotta · 2024-03-11T14:08:51Z

FYI @perrotta : #9060

Thank you @smuzaffar !

smuzaffar · 2024-03-11T21:52:14Z

@perrotta , consistent eigen flags PR for 14.0.X is #9062

Make Eigen alignment setting consistent

1580fa1

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels Feb 29, 2024

makortel mentioned this pull request Feb 29, 2024

Segfault in gbl::GblTrajectory::prepare() cms-sw/cmssw#44188

Closed

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2024

makortel commented Mar 5, 2024

View reviewed changes

lwtnn.spec Show resolved Hide resolved

Upgrade lwtnn to 2.14.1 to have a fix in their CMake file

d2f3620

cmsbuild added tests-pending and removed tests-approved labels Mar 7, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 8, 2024

makortel closed this Mar 8, 2024

makortel reopened this Mar 8, 2024

makortel closed this Mar 8, 2024

smuzaffar mentioned this pull request Mar 11, 2024

Using consistent Eigen alignment settings #9060

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Test making Eigen alignment setting consistent #9043

[DO NOT MERGE] Test making Eigen alignment setting consistent #9043

makortel commented Feb 29, 2024

makortel commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

cmsbuild commented Feb 29, 2024 •

edited

Loading

cmsbuild commented Mar 1, 2024

iarspider commented Mar 6, 2024 via email •

edited

Loading

cmsbuild commented Mar 7, 2024

makortel commented Mar 7, 2024

cmsbuild commented Mar 8, 2024

makortel commented Mar 8, 2024

smuzaffar commented Mar 8, 2024

makortel commented Mar 8, 2024

perrotta commented Mar 11, 2024

smuzaffar commented Mar 11, 2024

perrotta commented Mar 11, 2024

smuzaffar commented Mar 11, 2024

[DO NOT MERGE] Test making Eigen alignment setting consistent #9043

[DO NOT MERGE] Test making Eigen alignment setting consistent #9043

Conversation

makortel commented Feb 29, 2024

makortel commented Feb 29, 2024

cmsbuild commented Feb 29, 2024

cmsbuild commented Feb 29, 2024 • edited Loading

cmsbuild commented Mar 1, 2024

Comparison Summary

iarspider commented Mar 6, 2024 via email • edited Loading

cmsbuild commented Mar 7, 2024

makortel commented Mar 7, 2024

cmsbuild commented Mar 8, 2024

Unit Tests

RelVals

makortel commented Mar 8, 2024

smuzaffar commented Mar 8, 2024

makortel commented Mar 8, 2024

perrotta commented Mar 11, 2024

smuzaffar commented Mar 11, 2024

perrotta commented Mar 11, 2024

smuzaffar commented Mar 11, 2024

cmsbuild commented Feb 29, 2024 •

edited

Loading

iarspider commented Mar 6, 2024 via email •

edited

Loading