Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildRule: Fix emdplugin cache for multiarch builds #8990

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

smuzaffar
Copy link
Contributor

We had stopped building cuda/romc backends of alpaka for extra micro-archs of MULTIARCHS/SKYLAKE IBs. Thsi caused runtime issue as the lib/arch/microarch/.edmplugin is a symlink to lib/arch/.edmplugin and CMS FW was trying to load the CudaAsync.so libs from the ``lib/arch/microarch( as thelib/arch/microarch/.edmplugin` still had the ref to it). The buildrule update fixes these issue and instead of creaing symlink it now properly creates a separate `.edmplugincache` file for each `lib/arch/microarch/.edmplugin`

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_1_X/master.

@smuzaffar, @aandvalenzuela, @iarspider, @cmsbuild can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

Pull request #8990 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-674021/37264/summary.html
COMMIT: 0bb3bc9
CMSSW: CMSSW_14_1_X_2024-02-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8990/37264/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit e90c30f into IB/CMSSW_14_1_X/master Feb 7, 2024
10 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-5 branch March 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants