Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF: make tensorflow_mkldnn_contraction_kernel configurable #8972

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

+externals

this does not change the default TF build options. By default TF still builds with old options

bazel --batch --output_user_root ../build build -s --verbose_failures --distinct_host_configuration=false --copt=-msse3 --config=opt --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 -j 16 --config=noaws --config=nogcp --config=nohdfs --config=nonccl //tensorflow/tools/pip_package:build_pip_package

@smuzaffar smuzaffar merged commit 51a9cd3 into IB/CMSSW_14_0_X/master Jan 29, 2024
4 of 5 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6df902/37084/summary.html
COMMIT: c70cdb3
CMSSW: CMSSW_14_0_X_2024-01-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8972/37084/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants