[CLHEP] Update to version 2.4.7.1 #8748

smuzaffar · 2023-10-11T20:37:34Z

smuzaffar · 2023-10-11T20:37:46Z

please test

cmsbuild · 2023-10-11T20:37:59Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2023-10-11T20:56:45Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35143/summary.html
COMMIT: 93cd784
CMSSW: CMSSW_13_3_X_2023-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8748/35143/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


FAILED: CMakeFiles/install.util 
cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/clhep/2.4.7.0-a40284fe541d1aab36684854ca8393ce/build && /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02806/el8_amd64_gcc12/external/cmake/3.25.2-286587a5b04682914f36aa1a7526e333/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.itmv2e (%install)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+clhep+2.4.7.0-a40284fe541d1aab36684854ca8393ce
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.itmv2e (%install)

add https://gitlab.cern.ch/CLHEP/CLHEP/-/commit/b41bba9fc51c5b580a4b2b9e325f7fe3a2f7ffe7 fix

smuzaffar · 2023-10-12T06:59:23Z

please test

cmsbuild · 2023-10-12T06:59:36Z

Pull request #8748 was updated.

cmsbuild · 2023-10-12T19:55:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35146/summary.html
COMMIT: 5433228
CMSSW: CMSSW_13_3_X_2023-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8748/35146/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update tag for RecoBTag-Combined to V01-18-00 #8750

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35146/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35146/git-merge-result

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 63451 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 155161
DQMHistoTests: Total nulls: 269
DQMHistoTests: Total successes: 3201468
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.10599999999999998 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.308 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 12634.0 ): 0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.978 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.564 KiB SiStrip/MechanicalView
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 18 / 48 workflows

smuzaffar · 2023-10-13T14:56:09Z

please test

cmsbuild · 2023-10-13T14:56:11Z

Pull request #8748 was updated.

cmsbuild · 2023-10-14T03:06:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35184/summary.html
COMMIT: d59e404
CMSSW: CMSSW_13_3_X_2023-10-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8748/35184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 62637 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 155141
DQMHistoTests: Total nulls: 269
DQMHistoTests: Total successes: 3201488
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.10599999999999998 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.308 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 12634.0 ): 0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.978 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.564 KiB SiStrip/MechanicalView
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 18 / 48 workflows

smuzaffar · 2023-10-16T08:36:29Z

please test

smuzaffar · 2023-10-16T08:41:45Z

@civanch , clhep 2.4.7.1 update shows a lot of reco and dqm differences (see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_3_X_2023-10-13-1100+d12604/59241/validateJR.html ) . Looks like it has same differences as we have when we moved to Geant4 11.1.2 . Can you please check and are these differences expected for clhep update?

cmsbuild · 2023-10-16T21:03:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12604/35199/summary.html
COMMIT: d59e404
CMSSW: CMSSW_13_3_X_2023-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8748/35199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 62637 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 155141
DQMHistoTests: Total nulls: 269
DQMHistoTests: Total successes: 3201488
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.10599999999999998 KiB( 49 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.308 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 12634.0 ): 0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.288 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.978 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.564 KiB SiStrip/MechanicalView
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 18 / 48 workflows

civanch · 2023-10-17T09:51:58Z

@smuzaffar , it is expected, because in this version of MixMax random generator a bug was fixed, which is seen when number of calls is big. It is non-reproducibility due to not proper initialisation of all field of random seed. With ordinary statistics the problem was not seen. In CMS run the event is reach and many random numbers are used.

So, having this version of CLHEP in 13_3_X is our goal but we need to decide if validation on base of pre-release validation is enough. I think so but the agreement with release managers and PPD is required.

smuzaffar · 2023-10-17T13:41:07Z

thanks @civanch , so I leave this PR as it is. May be you can discuss this with release managers/PPD during ORP today

smuzaffar · 2023-10-17T18:49:38Z

+externals

cmsbuild · 2023-10-17T18:49:56Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2023-10-17T23:47:04Z

+1

[CLHEP] Update to version 2.4.7.0

93cd784

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels Oct 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 11, 2023

Update clhep.spec

5433228

add https://gitlab.cern.ch/CLHEP/CLHEP/-/commit/b41bba9fc51c5b580a4b2b9e325f7fe3a2f7ffe7 fix

cmsbuild added tests-started and removed tests-rejected labels Oct 12, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2023

Update clhep.spec

d59e404

smuzaffar changed the title ~~[CLHEP] Update to version 2.4.7.0~~ [CLHEP] Update to version 2.4.7.1 Oct 13, 2023

cmsbuild added tests-pending and removed tests-approved labels Oct 13, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 13, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2023

cmsbuild added tests-started and removed tests-approved labels Oct 16, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 16, 2023

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Oct 17, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 17, 2023

cmsbuild merged commit dad9f5c into IB/CMSSW_13_3_X/master Oct 17, 2023

smuzaffar deleted the smuzaffar-patch-2 branch October 18, 2023 05:34

smuzaffar mentioned this pull request Oct 19, 2023

[ASAN] AddressSanitizer: new-delete-type-mismatch cms-sw/cmssw#43063

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CLHEP] Update to version 2.4.7.1 #8748

[CLHEP] Update to version 2.4.7.1 #8748

smuzaffar commented Oct 11, 2023

smuzaffar commented Oct 11, 2023

cmsbuild commented Oct 11, 2023

cmsbuild commented Oct 11, 2023

smuzaffar commented Oct 12, 2023

cmsbuild commented Oct 12, 2023

cmsbuild commented Oct 12, 2023

smuzaffar commented Oct 13, 2023

cmsbuild commented Oct 13, 2023

cmsbuild commented Oct 14, 2023

smuzaffar commented Oct 16, 2023

smuzaffar commented Oct 16, 2023

cmsbuild commented Oct 16, 2023

civanch commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

antoniovilela commented Oct 17, 2023

[CLHEP] Update to version 2.4.7.1 #8748

[CLHEP] Update to version 2.4.7.1 #8748

Conversation

smuzaffar commented Oct 11, 2023

smuzaffar commented Oct 11, 2023

cmsbuild commented Oct 11, 2023

cmsbuild commented Oct 11, 2023

External Build

smuzaffar commented Oct 12, 2023

cmsbuild commented Oct 12, 2023

cmsbuild commented Oct 12, 2023

Comparison Summary

smuzaffar commented Oct 13, 2023

cmsbuild commented Oct 13, 2023

cmsbuild commented Oct 14, 2023

Comparison Summary

smuzaffar commented Oct 16, 2023

smuzaffar commented Oct 16, 2023

cmsbuild commented Oct 16, 2023

Comparison Summary

civanch commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

smuzaffar commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

antoniovilela commented Oct 17, 2023