Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRAMV1] Fix for PGO/Multivec env setup #8731

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

smuzaffar
Copy link
Contributor

This fixes the issue [a] where scram sets/reset env variable value if it generated multiple time from the hook script. This only effects multi-vectorizations latest builds where CMSSW_CPU_TYPE is generated multiple time for PGO build

[a]

> export USER_SCRAM_TARGET=auto   
> cmsenv
> echo $CMSSW_CPU_TYPE $SCRAM_TARGET
scram_haswell auto
> cmsenv
> echo $CMSSW_CPU_TYPE $SCRAM_TARGET
default auto
> cmsenv
> echo $CMSSW_CPU_TYPE $SCRAM_TARGET
scram_haswell auto

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef4f2/34975/summary.html
COMMIT: 8e38ec3
CMSSW: CMSSW_13_3_X_2023-09-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8731/34975/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358292
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 195cc6e into IB/CMSSW_13_3_X/master Oct 1, 2023
smuzaffar added a commit that referenced this pull request Oct 1, 2023
@smuzaffar smuzaffar deleted the smuzaffar-patch-4 branch October 4, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants