Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gsl] Updated tool file to add gsl/bin in to PATH env #8711

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@agrohsje
Copy link

hi @smuzaffar, will you also back port to 10_6 and maybe 12_4 ? @cms-sw/generators-l2

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e16d50/34838/summary.html
COMMIT: 48cf7f7
CMSSW: CMSSW_13_3_X_2023-09-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8711/34838/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.5 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358016
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit fcd6223 into IB/CMSSW_13_3_X/master Sep 20, 2023
@smuzaffar
Copy link
Contributor Author

hi @smuzaffar, will you also back port to 10_6 and maybe 12_4 ? @cms-sw/generators-l2

For other release cycles and already build releases, we can fix it via SCRAM global runtime hooks. SCRAM global runtime hooks are run when one runs cmsenv. I can add a hook to include gsl/bin in PATH so that old releases can pick gsl-config from cms externals

@agrohsje
Copy link

Thanks @smuzaffar. Sounds good. Please let me know when this becomes available so that we can update the affected gridpacks.

@smuzaffar
Copy link
Contributor Author

#8712 adds scram site based runtime hook. I will let you know once it is merged and deployed on cvmfs.

@smuzaffar
Copy link
Contributor Author

@agrohsje , new scram hook is now available on cvmfs. It now properly sets the gsl/bin path for already existing releases

lxplus> scram p  CMSSW_10_6_21
lxplus> cd CMSSW_10_6_21 
lxplus> cmsenv
lxplus> which gsl-config
/cvmfs/cms.cern.ch/slc7_amd64_gcc700/external/gsl/2.2.1-pafccj2/bin/gsl-config
lxplus> gsl-config --prefix
/cvmfs/cms.cern.ch/slc7_amd64_gcc700/external/gsl/2.2.1-pafccj2
lxplus> gsl-config --libs
-L/cvmfs/cms.cern.ch/slc7_amd64_gcc700/external/gsl/2.2.1-pafccj2/lib -lgsl -lgslcblas -lm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants