[TEST] Revert "TF: Use consistent abseil version in TensorFlow" #8685
Conversation
|
A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
please test for el8_aarch64_gcc11 |
|
why not just apply the third_party/absl/com_google_absl_fix_mac_and_nvcc_build.patch patch? |
I am not sure if it will apply as it is (the issue is supposedly fixed). |
|
may be not the complete patch but |
|
ok, new absl already has the change https://github.com/abseil/abseil-cpp/blob/c2435f8342c2d0ed8101cb43adfd605fdc52dca2/absl/base/config.h#L939 |
|
cms-externals/tensorflow#12 was done to make sure we use consistent version of absl. If reverting cms-externals/tensorflow#12 works for aarch then try update cmsdst/absl to use the same commit as used by TF |
|
Will do. |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Building edm plugin tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so lto-wrapper: warning: using serial compilation of 4 LTRANS jobs /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/cc4qAELI.ltrans0.ltrans.o: in function `DeepMETProducer::DeepMETProducer(edm::ParameterSet const&, tensorflow::SessionCache const*)': :(.text+0x75d8): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: :(.text+0x75fc): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so] Error 1 Leaving library rule at src/RecoMET/METPUSubtraction/plugins Entering library rule at RecoMET/METPUSubtraction >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/DeepMETHelper.cc >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/MvaMEtUtilities.cc |
|
please test for el8_aarch64_gcc11 |
|
Pull request #8685 was updated. |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Building edm plugin tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so lto-wrapper: warning: using serial compilation of 4 LTRANS jobs /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/ccKVMYdx.ltrans0.ltrans.o: in function `DeepMETProducer::DeepMETProducer(edm::ParameterSet const&, tensorflow::SessionCache const*)': :(.text+0x75d8): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: :(.text+0x75fc): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so] Error 1 Leaving library rule at src/RecoMET/METPUSubtraction/plugins Entering library rule at RecoMET/METPUSubtraction >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/DeepMETHelper.cc >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/MvaMEtUtilities.cc |
|
Tensorflow build was successful, but cmssw failed to build (because both absl version and workaround were reverted). |
|
why have not we tried #8685 (comment) yet ? |
|
Working on it. |
are there any blocker for this? this should not have taken 2 days |
|
Pull request #8685 was updated. |
|
please test for el8_aarch64_gcc11 |
cmsbuild
added
tests-started
tests-rejected
and removed
tests-pending
tests-started
labels
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Building edm plugin tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so lto-wrapper: warning: using serial compilation of 4 LTRANS jobs /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/ccukJAuz.ltrans0.ltrans.o: in function `DeepMETProducer::DeepMETProducer(edm::ParameterSet const&, tensorflow::SessionCache const*)': :(.text+0x75d8): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/../../../../aarch64-redhat-linux-gnu/bin/ld.bfd: :(.text+0x75fc): undefined reference to `tensorflow::TensorShapeBase::TensorShapeBase(absl::lts_20230125::Span)' collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_aarch64_gcc11/src/RecoMET/METPUSubtraction/plugins/RecoMETMETPUSubtraction_plugins/libRecoMETMETPUSubtraction_plugins.so] Error 1 Leaving library rule at src/RecoMET/METPUSubtraction/plugins Entering library rule at RecoMET/METPUSubtraction >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/DeepMETHelper.cc >> Compiling /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-08-31-2300/src/RecoMET/METPUSubtraction/src/MvaMEtUtilities.cc |
|
Pull request #8685 was updated. |
|
please test for el8_aarch64_gcc11 |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4443f2/34666/summary.html External BuildI found compilation error when building: Requested to quit. Requested to quit. Requested to quit. Requested to quit. * The action "build-external+tensorflow-sources+2.12.0-d6fa584e76259faf9b5b73c14464a668" was not completed successfully because Failed to build tensorflow-sources. Log file in /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_aarch64_gcc11/external/tensorflow-sources/2.12.0-d6fa584e76259faf9b5b73c14464a668/log. Final lines of the log file: /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/include/arm_neon.h(1292): error: identifier "__builtin_aarch64_addhn2v2di" is undefined /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/include/arm_neon.h(1299): error: identifier "__builtin_aarch64_addhn2v8hi" is undefined /data/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.4.1/include/arm_neon.h(1308): error: identifier "__builtin_aarch64_addhn2v4si" is undefined |
|
closing in favor of #8692 |
Reverts #8675
Compilation on ARM fails with: