Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpaka to pickup fix for C++20 #8567

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

iarspider
Copy link
Contributor

Backport from #8561, as requested by @smuzaffar

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_2_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeb1ce/33388/summary.html
COMMIT: 9e017fb
CMSSW: CMSSW_13_2_X_2023-06-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8567/33388/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
159.02 step 3
159.03 step 3
160.02 step 3
160.03 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 11365 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3200270
  • DQMHistoTests: Total failures: 14701
  • DQMHistoTests: Total nulls: 178
  • DQMHistoTests: Total successes: 3185369
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@iarspider
Copy link
Contributor Author

@fwyzard FYI

@fwyzard
Copy link
Contributor

fwyzard commented Jun 27, 2023

👍🏻

@smuzaffar
Copy link
Contributor

please test

any objections @fwyzard on this update? your last comment is not clear

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeb1ce/33549/summary.html
COMMIT: 9e017fb
CMSSW: CMSSW_13_2_X_2023-07-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8567/33549/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.3 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 20 lines from the logs
  • Reco comparison results: 2865 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3193832
  • DQMHistoTests: Total failures: 1227
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3192577
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@fwyzard
Copy link
Contributor

fwyzard commented Jul 5, 2023

my comment was a "thumbs up"... no objections from my side

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants