Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4: cleanup unused variables and use GEANT4_USE_USOLIDS="all" #8564

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 22, 2023

As discussed with @civanch @bsunanda

  • cleanup unused configuration variables [a]
  • GEANT4_USE_USOLIDS=CONS;POLYCONE;POLYHEDRA did not show any real advantage so set it back to all

[a]

  Manually-specified variables were not used by the project:

    CMAKE_STATIC_LIBRARY_CXX_FLAGS
    CMAKE_STATIC_LIBRARY_C_FLAGS
    GEANT4_USE_USOLIDS-ADVANCED

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_13_2_GEANT4_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/g4.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_13_2_GEANT4_X

@cmsbuild
Copy link
Contributor

Pull request #8564 was updated.

@smuzaffar smuzaffar merged commit f015b0d into IB/CMSSW_13_2_X/g4 Jun 22, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa4c4e/33336/summary.html
COMMIT: f7b8c2e
CMSSW: CMSSW_13_2_GEANT4_X_2023-06-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8564/33336/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa4c4e/33336/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa4c4e/33336/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 45 lines from the logs
  • Reco comparison results: 63041 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3200270
  • DQMHistoTests: Total failures: 157443
  • DQMHistoTests: Total nulls: 229
  • DQMHistoTests: Total successes: 3042576
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.232 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 2.197 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.598 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.733 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 4.883 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 16 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants