Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] Update llvm.spec with latest hash #8538

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 4, 2023

Update to clang static analyzer core to use scoped named for variable when calculating issue hash

backport of #8537

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Jun 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db383b/32967/summary.html
COMMIT: 26f78f9
CMSSW: CMSSW_13_1_X_2023-06-04-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8538/32967/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 26 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 1217
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3220352
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

@gartung , this looks good, do you want to run any local tests against /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8538/32967/install.sh to see if your changes actually work?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db383b/32989/summary.html
COMMIT: 26f78f9
CMSSW: CMSSW_13_1_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8538/32989/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Jun 5, 2023

It should work, but I will run with this version of clang 14 just to be sure.

@gartung
Copy link
Member Author

gartung commented Jun 5, 2023

I have verified that it produces the expected results.

@smuzaffar
Copy link
Contributor

+externals

@perrotta , @rappoccio feel free to integrate it in 13.1.X

@smuzaffar smuzaffar changed the title Update llvm.spec with latest hash [13.1.X] Update llvm.spec with latest hash Jun 7, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2023

@gartung @smuzaffar maybe I missed it, but why only in 13_1_X and not in master?

@smuzaffar
Copy link
Contributor

it is backport of #8537 from master. I have updated the description of this PR

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2023

backport of #8537

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2023

+1

@cmsbuild cmsbuild merged commit 89df526 into cms-sw:IB/CMSSW_13_1_X/master Jun 7, 2023
@gartung gartung deleted the patch-2 branch August 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants