Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecoMuon-TrackerSeedGenerator to V00-05-00 #8459

Conversation

perrotta
Copy link
Contributor

It replaces https://github.com/cms-sw/cmsdist/pull/8458/files which has conflicts

Move RecoMuon-TrackerSeedGenerator data to new tag, see
cms-data/RecoMuon-TrackerSeedGenerator#5

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test
(just to be sure...)

@missirol
Copy link
Contributor

@cms-sw/externals-l2 , we would need a backport of this PR to 13_0_X. Is that something you could take care of ? (is it okay to ask here, or is there a procedure to follow ?)

@aandvalenzuela
Copy link
Contributor

Hello @missirol,

Find backport at #8461.
Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa22c8/32087/summary.html
COMMIT: 7aaed3f
CMSSW: CMSSW_13_1_X_2023-04-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8459/32087/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa22c8/32087/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa22c8/32087/git-merge-result

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460915
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460887
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 4b3cb5a into IB/CMSSW_13_1_X/master Apr 21, 2023
@perrotta perrotta deleted the update-RecoMuon-TrackerSeedGenerator-to-V00-05-00-1 branch April 21, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants