Rename jemalloc libraries with debug and profiling options enabled.

[gartung]

No description provided.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[gartung]

please test with cms-sw/cmssw#41071

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8deb79/31321/summary.html
COMMIT: 9020aea
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8389/31321/install.sh to create a dev area with all the needed externals and cmssw changes.

[cmsbuild]

Pull request #8389 was updated.

[gartung]

please test with cms-sw/cmssw#41071

[smuzaffar]

@gartung , looks like you also need to update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_13_1_X/master/cmssw-drop-tools.file and remove jemalloc-debug and jemalloc-prof from there otherwise these tools will not be available in cmssw env.

[cmsbuild]

Pull request #8389 was updated.

[smuzaffar]

please test with cms-sw/cmssw#41071

I have updated cmssw-drop-tool

[cmsbuild]

Pull request #8389 was updated.

[gartung]

please test with cms-sw/cmssw#41071

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8deb79/31385/summary.html
COMMIT: a8539f1
CMSSW: CMSSW_13_1_X_2023-03-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8389/31385/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Make jets in TauGenJetProducer from taus which are not decayed cmssw#41064
• @hahnjo Update G4HepEm to new pre-release #8368

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8deb79/31385/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8deb79/31385/git-merge-result

Comparison Summary

Summary:

• You potentially removed 21 lines from the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550854
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@gartung , this look good now. cmsRunJE is now properly linked to libjemalloc-prof. While we are at this, may be you can clean these tools up and move the common section from jemalloc*.spec in to jemalloc-common.file. I am thinking that %install and %post sections can be moved to jemalloc-common.file e.g. in jemalloc-common we can have

%install
make install
%if "%{n}" != "jemalloc"
  # Rename jemalloc libs
  mv %{i}/lib/libjemalloc.so.2 %{i}/lib/lib%{n}.so.2
  rm %{i}/lib/libjemalloc.so
  ln -sf lib%{n}.so.2 %{i}/lib/lib%{n}.so
  patchelf --set-soname  lib%{n}.so.2  %{i}/lib/lib%{n}.so.2
  # Make sure there are no other libs. If there are then we should fail and updade the recipe
  if [ $(ls %{i}/lib/lib* | grep -v lib%{n}. | wc -l) -gt 0 ] ; then exit 1; fi
%endif

%post
%{relocateConfig}bin/jemalloc.sh
%{relocateConfig}bin/jemalloc-config

and remove %install and %post` sections from the jemalloc*.spec files

[gartung]

please test with cms-sw/cmssw#41071

[cmsbuild]

Pull request #8389 was updated.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8deb79/31406/summary.html
COMMIT: 7ea1fad
CMSSW: CMSSW_13_1_X_2023-03-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8389/31406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550857
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals
thanks @gartung , looks good now

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)