Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package the HIP/ROCm and ROCrand libraries [13.0.x] #8371

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Package the HIP/ROCm and ROCrand libraries [13.0.x] #8371

merged 3 commits into from
Mar 22, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 10, 2023

Package the core HIP/ROCm libraries and tools, and the ROCrand libraries.
Update the tool files for rocm-rocrand and alpaca-rom accoridngly.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2023

backport #8370

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2023 •
edited
Loading

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from 941baf2 to a56ecb2 Compare March 10, 2023 08:00
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from a56ecb2 to fd5a541 Compare March 10, 2023 08:07
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from fd5a541 to 2cff581 Compare March 10, 2023 08:26
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from 2cff581 to 8d39494 Compare March 10, 2023 08:29
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from 8d39494 to 84603e8 Compare March 10, 2023 09:52
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from 84603e8 to ed70667 Compare March 10, 2023 10:40
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch 2 times, most recently from 8398f95 to ff5a94b Compare March 10, 2023 10:49
@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

fwyzard
fwyzard commented Mar 10, 2023
View reviewed changes
cmssw-tool-conf.spec
@@ -1,4 +1,4 @@
### RPM cms cmssw-tool-conf 53.0
### RPM cms cmssw-tool-conf 53.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar is this the right way to have different cmssw-tool-conf files for CMSSW 13.0.x vs 13.1.x ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I just increment the major version when a new tool is added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... but 54.0 is already used in 13.1.x, which adds tools I think we do not want to backport to 13.0.x.

So I've used 55.0 for the 13.1.x branch, and 53.1 for the 13.0.x branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, sorry I did not realize that it is 13.0.x PR. yes 53.1 seems right

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2023

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2426e7/31189/summary.html
COMMIT: ff5a94b
CMSSW: CMSSW_13_0_X_2023-03-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8371/31189/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/CUDAWrapper/src/HeterogeneousTestCUDAWrapper/libHeterogeneousTestCUDAWrapper_nv.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmWrapper/src/HeterogeneousTestROCmWrapper/libHeterogeneousTestROCmWrapper_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1740: tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc11/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousCore/ROCmUtilities/bin/rocmIsEnabled/librocmIsEnabled_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/CUDADevice/src/HeterogeneousTestCUDADevice/libHeterogeneousTestCUDADevice_nv.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/CUDAKernel/src/HeterogeneousTestCUDAKernel/libHeterogeneousTestCUDAKernel_nv.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmDevice/src/HeterogeneousTestROCmDevice/libHeterogeneousTestROCmDevice_rocm.a to productstore area:

@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from ff5a94b to 65121e5 Compare March 16, 2023 07:22
@fwyzard fwyzard force-pushed the IB/CMSSW_13_0_X/master_repackage_rocm branch from c2b093e to 599353a Compare March 21, 2023 00:39
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 21, 2023

please test

@cmsbuild
Copy link
Contributor

Pull request #8371 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 21, 2023

please test for el9_amd64_gcc11

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 21, 2023

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2426e7/31459/summary.html
COMMIT: 599353a
CMSSW: CMSSW_13_0_X_2023-03-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8371/31459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 19 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard fwyzard mentioned this pull request Mar 21, 2023
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2426e7/31460/summary.html
COMMIT: 599353a
CMSSW: CMSSW_13_0_X_2023-03-17-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8371/31460/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 75 lines to the logs
  • Reco comparison results: 64084 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 145333
  • DQMHistoTests: Total nulls: 261
  • DQMHistoTests: Total successes: 3405432
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.706 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 2.904 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -1.061 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.479 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.133 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2426e7/31461/summary.html
COMMIT: 599353a
CMSSW: CMSSW_13_0_X_2023-03-20-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8371/31461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 64 lines to the logs
  • Reco comparison results: 67729 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 174824
  • DQMHistoTests: Total nulls: 291
  • DQMHistoTests: Total successes: 3375911
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.454 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.607 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 1.668 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -1.236 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.787 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.492 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 18 / 47 workflows

@rappoccio
Copy link

@smuzaffar should we merge this one now? There are IB failures in the 13_1 but these seem unrelated to this PR.

@smuzaffar
Copy link
Contributor

+externals

looks good to go in 13.0.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

yes @rappoccio , this is ready to go in 13.0.X

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7222c29 into cms-sw:IB/CMSSW_13_0_X/master Mar 22, 2023
@fwyzard fwyzard deleted the IB/CMSSW_13_0_X/master_repackage_rocm branch March 22, 2023 16:05
@cmsbuild cmsbuild mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
backport-ok externals-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fwyzard @cmsbuild @rappoccio @smuzaffar @perrotta