Remove patch that does not work with head of Igprof/master

[gartung]

No description provided.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30213/summary.html
COMMIT: 837a20c
CMSSW: CMSSW_13_0_X_2023-01-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8269/30213/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -g -O3 -rdynamic CMakeFiles/igprof-analyse.dir/src/analyse.cc.o -o igprof-analyse  -Wl,-rpath,/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pcre/8.43-5dcc901acc02f624b22dd9840b2357e8/lib: -ldl /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pcre/8.43-5dcc901acc02f624b22dd9840b2357e8/lib/libpcre.so 
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/igprof/5.9.16-b7c5205c9c5dfdbf3ca80204e6907e9f/build'
[ 95%] Built target igprof-analyse
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/igprof/5.9.16-b7c5205c9c5dfdbf3ca80204e6907e9f/build'
make: *** [Makefile:152: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.FHWutG (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+igprof+5.9.16-b7c5205c9c5dfdbf3ca80204e6907e9f
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.FHWutG (%build)


[gartung]

@smuzaffar this pr was just to test with cms-externals/igprof#5

[gartung]

please test with cms-externals/igprof#5

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30230/summary.html
COMMIT: 837a20c
CMSSW: CMSSW_13_0_X_2023-01-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8269/30230/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555467
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@gartung , let me know when these PRs (this one and cms-externals/igprof#5) are ready to go in

[cmsbuild]

Pull request #8269 was updated.

[cmsbuild]

Pull request #8269 was updated.

[gartung]

@smuzaffar I merged the pull request for cms-externals/igprof and updated this pull request with the commit. It is ready for merging.

[gartung]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30284/summary.html
COMMIT: 6c50e98
CMSSW: CMSSW_13_0_X_2023-01-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8269/30284/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw [SCRAM] Fix iftool/elif filter #8275
• @fwyzard Update to ROCm 5.4.2 and TBB 2021.8.0 #8273

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30284/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30284/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testTriggerMonitors had ERRORS

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555467
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[gartung]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30360/summary.html
COMMIT: 6c50e98
CMSSW: CMSSW_13_0_X_2023-02-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8269/30360/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update tag for PhysicsTools-NanoAOD to V01-03-00 #8283
• @cms-sw [BuildRules] set TMPDIR so that hipcc can create temp file in cmssw/tmp/package directory #8279

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30360/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a53f1/30360/git-merge-result

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 75 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 268
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555205
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: found differences in 5 / 47 workflows

[gartung]

@smuzaffar can this be merged

[smuzaffar]

+externals
looks good to me

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)