-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pythia8][306] Pythia Update to fix tau decays #8139
Conversation
please test |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_6_X/master. @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28474/summary.html External BuildI found compilation warning when building: See details on the summary page. |
please test with cms-externals/pythia8#29 |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28477/summary.html External BuildI found compilation error when building: Requested to quit. Requested to quit. * The action "build-external+pythia8+306-ce7ac3b73ba2c31da89d239e7552db72" was not completed successfully because Failed to build pythia8. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc10/external/pythia8/306-ce7ac3b73ba2c31da89d239e7552db72/log. Final lines of the log file: | couplingsPtrIn src/HelicityMatrixElements.cc: In member function 'virtual void Pythia8::HMETwoFermions2GammaZ2TwoFermions::initConstants()': src/HelicityMatrixElements.cc:408:11: error: 'couplingsPtr' was not declared in this scope; did you mean 'Couplings'? 408 | sin2W = couplingsPtr->sin2thetaW(); | ^~~~~~~~~~~~ | Couplings src/HelicityMatrixElements.cc: In member function 'virtual void Pythia8::HMEZ2TwoFermions::initConstants()': src/HelicityMatrixElements.cc:681:10: error: 'couplingsPtr' was not declared in this scope; did you mean 'Couplings'? |
Pull request #8139 was updated. |
please test |
Pull request #8139 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f825/28487/summary.html Comparison SummarySummary:
|
From the discussion in Software Release meeting, this PR can be merged as soon as possible. The next step is to discuss with @cms-sw/generators-l2 and PPD if a backport to |
+externals @cms-sw/generators-l2 , @perrotta @rappoccio this PR includes the pythia8 fix for tau decays ( cms-externals/pythia8#29 ) . Feel free to include it for next 12.6.X IB/pre-release. Let us know if this should be backported to 12.4/12.5 release cycles |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Indeed, a back-port to 12_4 is needed as this will be used in the Run3 MC campaign we are starting now. Thanks so much! |
+1 |
See cms-externals/pythia8#29