Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-26-00-patches #8114

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_6_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-681629/27923/summary.html
COMMIT: 2cbd423
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8114/27923/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-681629/27923/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-681629/27923/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test createDBObjecs had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-681629/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16720 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 175499
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3257128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

ah these unit tests are already failing for IBs

@smuzaffar
Copy link
Contributor

hold
not merging yet the root 6.26

@smuzaffar smuzaffar closed this Oct 4, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 4, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-681629/27968/summary.html
COMMIT: 2cbd423
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8114/27968/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test createDBObjecs had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-681629/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16724 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 175502
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3257125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@iarspider
Copy link
Contributor Author

iarspider commented Oct 4, 2022 via email

@iarspider iarspider deleted the root-update-v6-26-00-patches-20221003 branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants