Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the develop branch to 2022.09.02 / b518e8c943a8 [12.5.x] #8069

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 5, 2022

Update the version of alpaka to the HEAD of the develop branch as of 2022.09.02, corresponding to the commit b518e8c943a8 .

Major changes:

  • change the interface of allocMappedBuf() to identify the platform with an explicit template parameter instead of deducing it from an (unused) device argument;
  • use CUDART_VERSION instead of BOOST_LANG_CUDA.

Other changes:

  • document new memory functionality;
  • add missing template parameters.

Update the version of alpaka to the HEAD of the develop branch as of 2022.09.02,
corresponding to the commit b518e8c943a8 .

Major changes:
  - change the interface of allocMappedBuf() to identify the platform
    with an explicit template parameter instead of deducing it from an
    (unused) device argument;
  - use CUDART_VERSION instead of BOOST_LANG_CUDA.

Other changes:
  - add missing template parameters.
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2022

backport #8068

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_5_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard fwyzard changed the title Update the develop branch to 2022.09.02 / b518e8c943a8 Update the develop branch to 2022.09.02 / b518e8c943a8 [12.5.x] Sep 5, 2022
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2022

please test with cms-sw/cmssw#39312

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa9dd/27346/summary.html
COMMIT: ffcffb5
CMSSW: CMSSW_12_5_X_2022-09-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8069/27346/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa9dd/27346/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1aa9dd/27346/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
@fwyzard , should this be merged along with cms-sw/cmssw#39312 ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 6, 2022

@fwyzard , should this be merged along with cms-sw/cmssw#39312 ?

Yes, they need to go together.

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

@cmsbuild cmsbuild merged commit c3482e5 into cms-sw:IB/CMSSW_12_5_X/master Sep 7, 2022
@fwyzard fwyzard deleted the IB/CMSSW_12_5_X/master_update_alpaka_2022.09.02 branch December 19, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants