-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vecgeom to 1.1.20 #7735
Update vecgeom to 1.1.20 #7735
Conversation
A new Pull Request was created by @iarspider for branch IB/CMSSW_12_4_X/geant4_vecgeom. @cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
Pull request #7735 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa11c2/23555/summary.html External BuildI found compilation error when building: been installed. -- Configuring incomplete, errors occurred! See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/external/vecgeom/v1.1.20-f0f1f54e8f4aeb64f5135f9f30b3c429/build/CMakeFiles/CMakeOutput.log". error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.UqpPce (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.UqpPce (%build) |
@iarspider , looks like we need veccore? |
geant4.spec should not be modified: -DGEANT4_BUILD_BUILTIN_BACKTRACE=OFF is useful, because it means all exceptions will be handled by CMSSW, no extra backtrace from Geant4. -DGEANT4_USE_USOLIDS="CONS;POLYCONE;POLYHEDRA" better to remove in order do not mess up new version of VecGeom and this extra configuration. We may use it later but now we need to have a branch which can run big statistics smoothly and be minimally differ from vecgeom 1.1.18. |
This reverts commit 8adc016.
Pull request #7735 was updated. |
Yes, looks like so. I will look into it. |
VecCore 0.8.0 is needed. Gabriele suggest following cmake options: -DBACKEND=YOUR-CHOSEN-BACKEND [Vc|Scalar] He said that the explicit path to VECCORE is needed. |
Pull request #7735 was updated. |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa11c2/23566/summary.html External BuildI found compilation warning when building: See details on the summary page. |
Pull request #7735 was updated. |
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test trackerMaterialAnalysisPlots had ERRORS RelVals
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
@civanch , this time I build vecgeom with buildin veccore but it still fails with the same error |
@smuzaffar , may we have some bad interference with dd4hep build? The recent does not explicitly depend on vecgeom, only on geant4. |
Pull request #7735 was updated. |
Pull request #7735 was updated. |
test parameters:
|
please test |
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test trackerMaterialAnalysisPlots had ERRORS ---> test testTauEmbeddingProducers had ERRORS RelVals
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
let merge this for G4VECGEOM Ib and build an IB to debug it. We can revert it back if needed |
@civanch , if I build geant4 and vecgeom in
|
@smuzaffar , I am just debugging CMSSW_12_4_G4VECGEOM_X_2022-05-04-1100. The crash happens on a boundary of a complex volume with the trace exactly as you show. It is not first track but unlucky track. So, it is VecGeom bug and I just make a ticket to VecGeom: In discussion with Gabriele Cosmo he suggested to switch from 11.0.1 to 11.0ref04 - April reference version of G4 + new VecGeom 1.2.0. The first includes improvements of handling of complex volumes inside Geant4. The second means also some change in cmake options. |
thanks @civanch . I guess G4 11.0ref04 is not publicly available, can you please provide the tar file for it? |
thanks, I am testing these now. By the way do we still need cms-externals/geant4@271d2ff...cms/v11.0.1 changes for 11.0Ref04? |
No, they are merged to the development version. |
Hi Shahzad
I have a tar file on /afs/cern.ch/work/b/banerjee/public/geant4.11.0.r04.tgz Please make use of it. Regards
Sunanda
…________________________________
From: Malik Shahzad Muzaffar ***@***.***
Sent: 05 May 2022 16:22
To: cms-sw/cmsdist
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmsdist] Update vecgeom to 1.1.20 (PR #7735)
thanks @civanch<https://github.com/civanch> . I guess G4 11.0ref04 is not publicly available, can you please provide the tar file for it?
—
Reply to this email directly, view it on GitHub<#7735 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORW23FNFCTQI3WBGSDVIPKSRANCNFSM5SEOO4UA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Closes #7734