Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[classlib] fixes for CS9 where glibc-header has dropped sys/sysctl.h #7672

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_3_X/master.

@smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22917/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/22917/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22917/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22917/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2337 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3984447
  • DQMHistoTests: Total failures: 9233
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3975192
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 227.297 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 11.963 KiB Generator/GenWeight
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22922/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/22922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 303 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3985363
  • DQMHistoTests: Total failures: 304
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3985028
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 94.298 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 12.579 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 136.8523 ): 6.245 KiB Physics/NanoAODDQM
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22934/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/22934/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS
---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4729 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3929280
  • DQMHistoTests: Total failures: 642
  • DQMHistoTests: Total nulls: 263
  • DQMHistoTests: Total successes: 3928353
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -20322.154 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -16.692 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.692 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.692 KiB RecoTauV/hpsPFTauProducerZTT_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.692 KiB RecoTauV/hpsPFTauProducerZTT_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVLooseIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVLooseIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVTightIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 10024.0,... ): -16.612 KiB RecoTauV/hpsPFTauProducerQCD_hpsPFTauDiscriminationByVTightIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 10024.0 ): ...
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22949/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/22949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4730 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3703700
  • DQMHistoTests: Total failures: 641
  • DQMHistoTests: Total nulls: 533
  • DQMHistoTests: Total successes: 3702504
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 49 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/22985/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/22985/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695123
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 49 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/23006/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/23006/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695074
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/23026/summary.html
COMMIT: 61ccd6f
CMSSW: CMSSW_12_3_X_2022-03-10-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7672/23026/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/23026/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d312/23026/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_3_X/master to IB/CMSSW_12_4_X/master March 11, 2022 08:14
@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch March 11, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants