Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same soruces for jemalloc and jemalloc-debug #7396

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar changed the title Use same soruces for jemallo and jemalloc-debug Use same soruces for jemalloc and jemalloc-debug Oct 19, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0934bc/19733/summary.html
COMMIT: 17e8689
CMSSW: CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7396/19733/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751090
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Oct 19, 2021

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

backport done
Successfully backported PR #7396 as #7399 for branch IB/CMSSW_12_0_X/master

@fwyzard
Copy link
Contributor

fwyzard commented Oct 25, 2021

Few years ago the jemalloc-debug package was explicitly not upgraded to jemalloc 5.0 because of it being extremely slow: #3329 .

Was it ever investigated, before switching ?

@smuzaffar
Copy link
Contributor Author

@fwyzard , it think issue there was the use of jemalloc-debug libs in production which were overriding the jemalloc libs. This happed as the jemalloc-debug toolfiles were not skipped/dropped 9 https://github.com/cms-sw/cmsdist/pull/3329/files#diff-e2f892bf13eeb6853c89ce59c658bb3b860981ce12ad8e32cc2063e79a5c08afR192 )

@fwyzard
Copy link
Contributor

fwyzard commented Oct 25, 2021

Ah, I see, so the issue was jemalloc-debug vs jemalloc, not jemalloc-debug 5.0 vs 4.5. Thanks for clarifying !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants