Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade lhapdf to 6.4.0, sets to 6.4.0b #7357

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Oct 4, 2021

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @mrodozov can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/19376/summary.html
COMMIT: 1c116d0
CMSSW: CMSSW_12_1_X_2021-10-04-1300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7357/19376/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@mkirsano
Copy link
Contributor Author

mkirsano commented Oct 4, 2021

please test

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

Pull request #7357 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

Pull request #7357 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/19380/summary.html
COMMIT: 0fa36a4
CMSSW: CMSSW_12_1_X_2021-10-04-1300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7357/19380/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/19380/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/19380/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31430 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 219016
  • DQMHistoTests: Total nulls: 100
  • DQMHistoTests: Total successes: 3000256
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: found differences in 7 / 39 workflows

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals
@cms-sw/generators-l2 is it needed for 12.1.0 release?

@agrohsje
Copy link

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_1_X/master to IB/CMSSW_12_2_X/master October 29, 2021 06:23
@mkirsano
Copy link
Contributor Author

mkirsano commented Nov 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 3, 2021

@qliphy , @perrotta please check if this should go in 12.2.X or not?

@qliphy
Copy link
Contributor

qliphy commented Nov 3, 2021

please test
the last test was done weeks ago and the log is lost. To check whether the differences really matters.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/20224/summary.html
COMMIT: 0fa36a4
CMSSW: CMSSW_12_2_X_2021-11-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7357/20224/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/20224/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbfa9e/20224/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35073 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 252944
  • DQMHistoTests: Total nulls: 142
  • DQMHistoTests: Total successes: 2648782
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 7 / 41 workflows

@agrohsje
Copy link

agrohsje commented Nov 8, 2021

+generators
re-sign; Mikhail above: Differences are possible. My tests give reasonable results.

@smuzaffar
Copy link
Contributor

@qliphy , @perrotta this is ready to go in 12.2.X

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants