Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVEL] Disable python for lhapdf: need lhapdf 6.3.0 for py3.9 #7096

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

smuzaffar
Copy link
Contributor

@davidlange6 , looks like lhapdf 6.2.3 does not build with python 3.9 that is why DEVEL IBs are not building
For now I have disabled the python for lhapdf, we need lhapdf 6.3.0 which works with python 3.9

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_12_0_DEVEL_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/devel.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar smuzaffar changed the title disable python for lhapdf: ned lhapdf 6.3.0 to go with py3.9 disable python for lhapdf: need lhapdf 6.3.0 to go with py3.9 Jul 3, 2021
@smuzaffar smuzaffar changed the title disable python for lhapdf: need lhapdf 6.3.0 to go with py3.9 [DEVEL] Disable python for lhapdf: need lhapdf 6.3.0 for py3.9 Jul 3, 2021
@smuzaffar
Copy link
Contributor Author

+externals
tests looks good, lets get this in DEVEL IBs

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/devel IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5905c4/16439/summary.html
COMMIT: 79d09c4
CMSSW: CMSSW_12_0_DEVEL_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7096/16439/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5905c4/16439/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5905c4/16439/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5133 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785682
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar deleted the lhapdf-py39-disable branch July 9, 2021 20:17
@cmsbuild cmsbuild mentioned this pull request Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants